Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better method for detecting lab for tests #6853

Closed
scottdraves opened this issue Feb 13, 2018 · 0 comments
Closed

better method for detecting lab for tests #6853

scottdraves opened this issue Feb 13, 2018 · 0 comments
Assignees

Comments

@scottdraves
Copy link
Contributor

scottdraves commented Feb 13, 2018

https://github.com/twosigma/beakerx/blob/master/test/run_tests.py#L35

instead of looking for the name of the conda env, just use a cmd line parameter to the script.

run_tests.py lab => run lab tests.
run_tests.py nb => run notebook tests.

if neither argument is given, then run "conda list" and look for "jupyterlab" in the results.

the notebook tests should also pass if explicitly run even if lab is installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants