Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing fields in NativeScript fingerprint #246

Merged
merged 2 commits into from
Apr 13, 2022
Merged

fix: missing fields in NativeScript fingerprint #246

merged 2 commits into from
Apr 13, 2022

Conversation

rvcas
Copy link
Member

@rvcas rvcas commented Apr 13, 2022

No description provided.

@rvcas rvcas requested a review from scarmuega as a code owner April 13, 2022 01:20
@scarmuega
Copy link
Member

thanks @rvcas !

could we add policy_id as part of the fingerprint? It would go like this:

EventData::NativeScript { policy_id, .. } => b
            .with_slot(&event.context.slot)
            .with_prefix("scpt")
            .append_optional(&event.context.tx_hash)?
            .append_slice(policy_id)?,

@rvcas rvcas merged commit aa3727c into main Apr 13, 2022
@rvcas rvcas deleted the rvcas/missing_fields branch April 13, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scarmuega scarmuega scarmuega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvcas @scarmuega