Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement block cbor probing #44

Merged
merged 1 commit into from
Feb 10, 2022
Merged

feat: Implement block cbor probing #44

merged 1 commit into from
Feb 10, 2022

Conversation

scarmuega
Copy link
Member

No description provided.

@scarmuega scarmuega requested a review from rvcas February 9, 2022 11:08
rvcas
rvcas approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@rvcas rvcas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is cool. do we need to probe for alonzo as well?

@scarmuega
Copy link
Member Author

yes, it would be a nice feature to probe for different hard forks on top of eras.

For the time being, since Alonzo primitives are backward compatible with previous Shelley blocks, we should be able to decode any block just by knowing if it's byron or shelley.

@scarmuega scarmuega marked this pull request as ready for review February 10, 2022 01:35
@scarmuega scarmuega merged commit 230cc28 into main Feb 10, 2022
@scarmuega scarmuega deleted the feat/probing branch February 10, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvcas rvcas rvcas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scarmuega @rvcas