feat(traverse): Decode Conway block headers properly #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates:
Ensure we can parse block header values of 5..6 as BabbageCompatible for both Babbage and Conway eras. The previous code had a Conway header falling back and attempting to parse as AlonzoCompatible.
Refactoring:
I changed AlonzoCompatible -> ShelleyCompatible for the block headers. BlockHeaders represent forward compatibility. In other words, we only get a new category for headers named after the first Era in which it changed.
Babbage -> BabbageCompatible since it now also includes conway BlockHeaders.
So, shelley, allegra, mary, alonzo blocks contain block headers that are shelley compatible.
babbage and conway blocks contain block headers that are babbage compatible.