Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instances missing from AllInstances #1485

Closed
durban opened this issue Dec 7, 2016 · 1 comment
Closed

Instances missing from AllInstances #1485

durban opened this issue Dec 7, 2016 · 1 comment
Assignees
@kailuowang
Milestone
1.0.0-MF

Comments

@durban
Copy link
Contributor

durban commented Dec 7, 2016

Not all type class instances are included in cats.instances.AllInstances (and thus they are also missing when import cats.implicits._). One example is the Eq[BitSet] instance. (See also the discussion at #1484.)

The reason is probably that they're included in cats.kernel.instances.AllInstances, but not in cats.instances.AllInstances. (Note, that the latter doesn't extend the former, but instead every separate *Instances trait tend to extend its pair in kernel. For example, cats.instances.StringInstances extends cats.kernel.instances.StringInstances.)
@durban
Copy link
Contributor Author

durban commented Apr 6, 2017

Can we put this into the cats-1.0.0 milestone? (Because I don't think it can be fixed in a binary compatible manner.)

@kailuowang kailuowang added this to the cats-1.0.0 milestone Apr 6, 2017
@kailuowang kailuowang mentioned this issue Apr 7, 2017
Merged
@kailuowang kailuowang self-assigned this Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kailuowang kailuowang

Labels
None yet
Projects
None yet
Milestone
1.0.0-MF
Development

No branches or pull requests
2 participants
@kailuowang @durban