-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add or
to ApplicativeError
#2242
Comments
we can add this to ApplicativeErrorOps in 1.x. |
true, handleErrorWith is all that is needed here. |
I could look into this if that's ok |
@barambani Please! |
@kailuowang do we have a list of changes that we hacked onto AnyVal classes that we would like to undo? Side question: should we prefer to keep typeclasses minimal, and have most methods on anyval extensions? It seems that we have almost all methods on the typeclass rather than thinking much about what could plausibly be optimized per type. I guess if binary compatibility was not a problem, and it won't be in 2.12, putting on the trait is strictly better. Maybe we just need to get the community to move to 2.12. |
@johnynek we don't have a list. I suppose when we move to a 2.12 only version we should review all these AnyVal classes and move the implementations of appropriate ones to the traits along with some "consistency" laws. It's shame that the community couldn't benefit from the better binary compat support from 2.12. Hopefully, now the ScalaCenter is helping, Spark can move over soon. |
Also, this implies you can make a
SemigroupK
if you have a MonadError. With an example error, you can make aMonoidK
. Or, if you have aMonadError[F, Unit]
, such as Option, you have an Alternative, I guess.The text was updated successfully, but these errors were encountered: