-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix all compiler warnings on Scala 2.13 #2893
Comments
Should cats 2.0 for Scala 2.13 contains instances for |
@poslegm thanks for looking at this. I would say no, cats 2.0 code base should not have any deprecation warnings. Thus we need to move all the
Update: I ended up creating the PR for replacing Stream in ExhausiveCheck. Also added Scala version specific folders for tests in the build. It is necessary when we move all the Stream instances and related tests to version specific folders Thanks!!! |
@poslegm I realized that we probably still want to keep Stream instances in 2.13 but deprecate them only on 2.13, this will require duplication the code in two scala version specific folders. I think I am going to take stab myself. |
Update |
Fatal-warning was temporarily disabled on Scala 2.13. Removing them might require breaking changes, hence we'd better do it before 2.0-RC1
This might be too much as a single task. We should probably achieve this with multiple PRs.
If anyone is interested, please feel free to choose a smaller scope to work on and announce it here. So that we can parallelize.
The text was updated successfully, but these errors were encountered: