Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scala 3] Test with enum-based adts #495

Closed
Tracked by #481
TimWSpence opened this issue Jun 6, 2022 · 3 comments
Closed
Tracked by #481

[Scala 3] Test with enum-based adts #495

TimWSpence opened this issue Jun 6, 2022 · 3 comments

Comments

@TimWSpence
Copy link
Member

We just copied the scala 2 adt definitions so we're not currently testing derivation for scala 3 enums

@wahtique
Copy link

wahtique commented Jun 10, 2022

Hi ! I was looking for a first issue to contribute and this look like a nice one to start :)
To clarify it :

@joroKr21
Copy link
Member

Hey @wahtique thank you for your interest to help!

  • So yes this is mostly about the ADTs in the file you linked, but they are not enums, because they were copied from the Scala 2 tests. What we need now is to add tests with Scala 3 enums - they don't have to be exactly the same, but it's probably easier to copy some of them and convert them to enums.
  • We should keep the Scala 2 tests because they ensure that we have source compatibility with Scala 2 so it should be relatively easy for people to migrate by just changing the imports.

@TimWSpence
Copy link
Member Author

Hey @wahtique I'm so sorry, I didn't see this and just opened #498. But if you spot gaps in my test coverage and want to add more then that would be brilliant! Thanks so much for wanting to get involved ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants