Koa still return 404 when with Authorized

[xujif]

version: 0.7.2
test code:

import { createExpressServer, createKoaServer,Action,JsonController, Get, Authorized } from "routing-controllers";
@JsonController()
export class TestClass {

    @Get('/no-auth')
    noAuth () {
        return {
            message: 'no auth'
        }
    }
    @Authorized()
    @Get('/auth')
    auth () {
        return {
            message: 'auth'
        }
    }
}
// when use createExpressServer can access /api/auth
const app = createKoaServer({
    routePrefix: "/api",
    currentUserChecker: (action: Action) => {
        return {
            user: 'user'
        }
    },
    authorizationChecker: (action: Action, roles: string[]) => {
        return true
    },
    controllers: [
        TestClass
    ]
})
console.log('listen at 8088')
app.listen(8088)

my package.json

{
  "name": "t",
  "version": "1.0.0",
  "main": "index.js",
  "license": "MIT",
  "dependencies": {
    "express": "^4.15.4",
    "koa": "^2.3.0",
    "koa-bodyparser": "^4.2.0",
    "koa-router": "^7.2.1",
    "routing-controllers": "^0.7.2",
    "typescript": "^2.5.2"
  }
}

[MichalLytek]

Maybe just use this?

authorizationChecker: async(action: Action, roles: string[]) => {
    return true
},

[xujif]

@19majkel94 it worked. but still a bug.

[MichalLytek]

@NoNameProvided
Looks like the error is here:
https://github.com/pleerock/routing-controllers/blob/master/src/driver/koa/KoaDriver.ts#L89

We just call next instead of return next(). And I found that @Diluka is the culprit:
177143a4#diff-112df671cfc9c4c162793234f846b6d0R105

[xujif]

@19majkel94 @NoNameProvided

    @Get('/user')
    user (@CurrentUser() user: any) {
        return user   // will return user  defined by currentUserChecker
    }
    @Get('/async-user')
    async asyncUser (@CurrentUser() user: any) {
        return user // raise 404 not found
    }

with a CurrentUser resolver ,still raise 404 when in a async action

[MichalLytek]

with a CurrentUser resolver ,still raise 404 when in a async action

Nope, just checked:

import "reflect-metadata"
import {
    createExpressServer,
    createKoaServer,
    Action,
    JsonController,
    Get,
    Authorized,
    CurrentUser,
} from "routing-controllers";
@JsonController()
export class TestClass {

    @Get('/no-auth')
    noAuth () {
        return {
            message: 'no auth'
        }
    }
    @Authorized()
    @Get('/auth')
    auth () {
        return {
            message: 'auth'
        }
    }

    @Get('/user')
    user (@CurrentUser() user: any) {
        return {
            user, // will return user  defined by currentUserChecker
            path: '/user',
        }   
    }

    @Get('/async-user')
    async asyncUser (@CurrentUser() user: any) {
        return {
            user, // raise 404 not found
            path: '/async-user',
        }
    }
}
// when use createExpressServer can access /api/auth
const app = createKoaServer({
    routePrefix: "/api",
    currentUserChecker: (action: Action) => {
        return {
            user: 'user'
        }
    },
    authorizationChecker: (action: Action, roles: string[]) => {
        return true
    },
    controllers: [
        TestClass
    ]
})
console.log('listen at 8088')
app.listen(8088)

[xujif]

@19majkel94 it's still 404 when add an "@Authorized":

    @Get('/async-user')
    @Authorized()
    async asyncUser (@CurrentUser() user: any) {
        return {
            user, // raise 404 not found
            path: '/async-user',
        }
    }

[MichalLytek]

it's still 404 when add an "@Authorized":

We will check that when the #283 PR has become merged.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.