Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alert-buster.js doesn't work on Firefox #2079

Closed
8 tasks done
theel0ja opened this issue Apr 5, 2022 · 8 comments
Closed
8 tasks done

alert-buster.js doesn't work on Firefox #2079

theel0ja opened this issue Apr 5, 2022 · 8 comments
Labels
duplicate This issue or pull request already exists

Comments

@theel0ja
Copy link

theel0ja commented Apr 5, 2022

Prerequisites

I tried to reproduce the issue when...

  • uBO is the only extension
  • uBO with default lists/settings
  • using a new, unmodified browser profile

Description

alert-buster.js doesn't work on Firefox, while it works on Chromium.

Screenshot 2022-04-05 at 13 17 55

A specific URL where the issue occurs

https://ylilauta.org/

Steps to Reproduce

  1. Install uBlock Origin on Firefox
  2. Enable Finnish Easylist Additions, which has a rule for ylilauta.org
  3. Get alerts on ylilauta.org even when alert-buster.js should be activated

Expected behavior

No alerts, logged into console. Works correctly on Chromium (tested with uBO 1.41.8 on Chromium 100.0.4896.62)

Actual behavior

Alerts are still shown, like seen in the picture in the "Description"

uBlock Origin version

1.42.0

Browser name and version

Tested on Firefox 98.0.2 and 99.0b8 (DevEdition)

Operating System and version

macOS 12.3.1

@krystian3w

This comment was marked as outdated.

@gorhill
Copy link
Member

gorhill commented Apr 5, 2022

Unable to reproduce an alert in the first place. You will have to provide details on how to trigger this alert.


Never mind, I get the alert when enabling FIN list.

@gorhill gorhill added unable to reproduce cannot reproduce the issue and removed unable to reproduce cannot reproduce the issue labels Apr 5, 2022
@gwarser gwarser added the bug Something isn't working label Apr 5, 2022
@gorhill
Copy link
Member

gorhill commented Apr 5, 2022

The issue is that the CSP for the page prevent inline scripts from being injected:

Content Security Policy: The page’s settings blocked the loading of a resource at inline (“script-src”).

Firefox's behavior differs from Chromium here.

@gorhill
Copy link
Member

gorhill commented Apr 5, 2022

Duplicate of #235.

https://bugzilla.mozilla.org/show_bug.cgi?id=1267027

@gorhill gorhill closed this as completed Apr 5, 2022
@gorhill gorhill added the duplicate This issue or pull request already exists label Apr 5, 2022
@krystian3w
Copy link

krystian3w commented Apr 5, 2022

For my side Tampermkoney disable most CSP with almost empty script in expert mode.

In that way I can still use:

  • google toolbar to translate pages,
  • $cps and $inline-script filtering.

So works better than security.csp.enable (no longer works - see https://bugzil.la/1754301 - removed im 99+ releases) and I guess better than scriptlet doctor (this still don't help load Google resources).

@Cerberus-tm
Copy link

Cerberus-tm commented Sep 12, 2022

For my side Tampermkoney disable most CSP with almost empty script in expert mode.

Hey, this sounds highly useful, how do you do this, or what should there be in the Tampermonkey script?

This works in Firefox?

@MasterKia
Copy link
Member

@Cerberus-tm
Copy link

@Cerberus-tm Install Scriptlet Doctor: https://github.com/JustOff/scriptlet-doctor/releases/download/1.2.5/scriptlet-doctor-quantum-1.2.5.xpi

Don't forget to disable "Limit to domains".

Hey, thanks, I was going to try Scriptlet Doctor too, though it won't download at the moment.

But I was also curious about the solution using Tampermonkey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

6 participants