Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shareable modal links #81

Closed
bobheadxi opened this issue Apr 24, 2020 · 0 comments · Fixed by #94
Closed

shareable modal links #81

bobheadxi opened this issue Apr 24, 2020 · 0 comments · Fixed by #94
Assignees
Labels
enhancement Website improvement
Milestone

Comments

@bobheadxi
Copy link
Member

bobheadxi commented Apr 24, 2020

we can already lead users directly to sections using URL hashes, e.g. https://ubclaunchpad.github.io/new/#join

It would be cool if we can allow users to link directly to, say, a project modal:

    const uri = window.location.search.substring(1); 
    const params = new URLSearchParams(uri);
    console.log(params.get('project'));
  1. scroll to #projects (or, when generating a link to modal, just include /#projects
  2. open up modal to params.get('project')
@bobheadxi bobheadxi added the enhancement Website improvement label Apr 24, 2020
@bobheadxi bobheadxi added this to the release milestone Apr 25, 2020
@bobheadxi bobheadxi self-assigned this Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Website improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant