Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Heading Component Page #24

Merged
merged 5 commits into from
Apr 20, 2024

Conversation

8845musign
Copy link
Contributor

@8845musign 8845musign commented Nov 17, 2023

Overview

  • Add Heading Component Page
  • PropTable is easy to understand.
  • Easy to see Table

Screenshot

http://localhost:4321/components

スクリーンショット 2024-04-20 16 45 13

http://localhost:4321/components/heading

スクリーンショット 2024-04-20 16 46 52
スクリーンショット 2024-04-20 16 46 58
スクリーンショット 2024-04-20 16 47 02
スクリーンショット 2024-04-20 16 47 08
スクリーンショット 2024-04-20 16 47 13
スクリーンショット 2024-04-20 16 47 19

PropTable

スクリーンショット 2024-04-20 16 48 08

  • Remove required columns and merge into name
  • Specify optional

Other Table

unify to proptable

スクリーンショット 2024-04-20 16 50 13

font-size: var(--text-body-sm-size);
line-height: var(--text-body-sm-tight-line);
white-space: nowrap;
padding: var(--size-spacing-sm) !important;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

important is to beat another PR style of markdown

@8845musign 8845musign marked this pull request as ready for review April 20, 2024 07:51
@8845musign 8845musign requested a review from takanorip as a code owner April 20, 2024 07:51
@takanorip takanorip merged commit f8202cb into ubie-oss:main Apr 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants