Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

アイコン名のキャメルケース表記を単語間に空白を加えて可読性を改善 #54

Merged
merged 1 commit into from
May 2, 2024

Conversation

YusukeHirao
Copy link

対象: https://vitals.ubie.life/elements/icons/

AS IS

  • アイコン画像の名前・可視ラベル共にアイコン名がキャメルケース
  • 可視ラベルのキャメルケースは単語ごとにspanでマークアップ

TO BE

  • アイコン画像の名前・可視ラベル共に可読性を上げるために単語間に空白を追加
  • spanのマークアップをやめて、CSSでword-wrap処理を調整
  • ビジュアルの変更は空白の追加です

@YusukeHirao YusukeHirao requested a review from takanorip as a code owner May 1, 2024 00:37
@takanorip
Copy link
Contributor

I thought it would be better not to include spaces in this doc title since these icon components name don't have any spaces.
However, since the code is copyable and adding spaces makes the implementation simpler, it seems like a good idea.
Thank you!

@takanorip takanorip merged commit f197e03 into ubie-oss:main May 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants