Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow run plugin to be used as a package manager #128

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

EyeCantCU
Copy link
Member

@EyeCantCU EyeCantCU commented Jul 3, 2023

This adds an install function to run that allows it to be used as a package manager on the package screen, providing categorizations of various commands

It does so by treating the passed command as a package from where the run plugin then executes it

Example:

  ...
  package_manager: yafti.plugin.run
    groups:
      Simple commands:
      - Hello World: echo 'Hello, World'
  ...

Result: 'Hello, World' is output in the console

This adds an install function to run that allows it to be used as a
package manager on the package screen, providing categorizations of
various commands

It does so by treating the passed command as a package from where
the run plugin then executes it

Example:
  ...
  package_manager: yafti.plugin.run
  groups:
    Simple commands:
    - Hello World: echo 'Hello, World'
  ...

Result: 'Hello, World' is output in the console
@marcoceppi
Copy link
Collaborator

This makes a lot of assumptions (like the package keyword). I'd rather move away from using the .install method and instead use .__call__. However, that breaks other things / assumptions in the Package Install screen. The truth is there's no real good way to make this work in a short period of time so I'm going to land this and I'll open a v1.0 issue to make plugins and package install screen work better together.

yafti/plugin/run.py Outdated Show resolved Hide resolved
There isn't a need for reassignment

Co-authored-by: Marco Ceppi <[email protected]>
@marcoceppi marcoceppi merged commit 7912e09 into ublue-os:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants