Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Add tests for links encapsulated in <> #638

Closed
1 task done
jimbonothing64 opened this issue Mar 26, 2024 · 2 comments
Closed
1 task done

[Bug]: Add tests for links encapsulated in <> #638

jimbonothing64 opened this issue Mar 26, 2024 · 2 comments
Labels

Comments

@jimbonothing64
Copy link
Contributor

Description of the bug

Links in markdown including ) should be enclosed in <> for compatibility.
uccser/cs-field-guide#2565

Adding <> around links should have worked in this pull:
uccser/cs-field-guide#2566

To verify verto is or is not at fault here, we should add a test with a link inside <>.

Steps To Reproduce

  1. Run tests

What device/software are you seeing this problem on?

No response

Additional Information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jimbonothing64
Copy link
Contributor Author

The markdown library we use implements the John Gruber's Spec, and not the CommonMark Spec.

It looks like John's spec doesn't include enclosing inline links with <>. But the CommonMark spec does.

@jimbonothing64
Copy link
Contributor Author

See #657 instead.

@jimbonothing64 jimbonothing64 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

1 participant