Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NR-JP2-file5.jp2-compare2base fails with third party libcms #540

Closed
mayeut opened this issue Jul 20, 2015 · 8 comments
Closed

NR-JP2-file5.jp2-compare2base fails with third party libcms #540

mayeut opened this issue Jul 20, 2015 · 8 comments
Milestone

Comments

@mayeut
Copy link
Collaborator

mayeut commented Jul 20, 2015

@detonin,

All is in the title. I see on CDash that you're not using ThirdParty. What version of libcms are you using ?

@detonin
Copy link
Contributor

detonin commented Jul 20, 2015

@mayeut
I'm using the one from macports:

lcms2 @2.6 (graphics)
Variants: universal
Description: LCMS is the Little Color Management System, a portable Color Matching Method (CMM) library which implements fast transforms between ICC profiles. Color management refers to techniques that ensure consistent color as images are transferred from scanners or cameras to monitors and printers.
Homepage: http://www.littlecms.com/
Library Dependencies: jpeg, tiff, zlib
Platforms: darwin
License: MIT
Maintainers: [email protected]

@detonin
Copy link
Contributor

detonin commented Jul 20, 2015

Strange: even if I enable thirdparty, it still uses my macports library

@mayeut
Copy link
Collaborator Author

mayeut commented Jul 20, 2015

Same for NR-DEC-issue171.jp2-71-decode-md5

@mayeut
Copy link
Collaborator Author

mayeut commented Jul 21, 2015

@detonin,

With 2.6 I get the same results, with 2.7 (latest) results changed again.
I will push 2.6 on master for now. Master was using 2.1 till now.

@mayeut
Copy link
Collaborator Author

mayeut commented Sep 6, 2015

@detonin,

Either we close this issue & dismiss #544 or (& I think it's best), Merge #544 & update data

@julienmalik
Copy link
Collaborator

Current master of lcms has a fix for all the misaligned address reported by UBSan, but the patch does not appear to be in 2.7...

@julienmalik
Copy link
Collaborator

I bet that's the one we want to clean up ubsan reports : mm2/Little-CMS@40c6403

@mayeut
Copy link
Collaborator Author

mayeut commented Apr 30, 2016

I'll update the PR to mm2/Little-CMS@0e8234e

@mayeut mayeut closed this as completed Apr 30, 2016
@mayeut mayeut added this to the OPJ v2.1.1 milestone Apr 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants