Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ Make Google site search the default #275

Merged
merged 1 commit into from
Oct 13, 2023
Merged

feat: ✨ Make Google site search the default #275

merged 1 commit into from
Oct 13, 2023

Conversation

knice
Copy link
Member

@knice knice commented Oct 13, 2023

What does this do/fix?

Adds Google site search to the search results page template, and removes default padding from the search results area.

QA

Links to relevant issues

Links to deployed, scaffolded demo:

@knice knice requested a review from Herm71 October 13, 2023 16:38
@knice knice added the enhancement New feature or request label Oct 13, 2023
Herm71
Herm71 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@Herm71 Herm71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great on local. In that nothing turns up. But the page width and whatnot is nice.

Herm71
Herm71 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@Herm71 Herm71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great on local. In that nothing turns up. But the page width and whatnot is nice.

@knice knice merged commit b43c434 into main Oct 13, 2023
@knice knice deleted the 2023-10-13-search-results branch December 21, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Herm71 Herm71 Herm71 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knice @Herm71