From 9d1cbac430a6465d09d4493f598c31e09a44fdc8 Mon Sep 17 00:00:00 2001 From: Jason Chafin Date: Thu, 12 Oct 2023 08:34:24 -0700 Subject: [PATCH 1/2] fix: :bug: Correct issue of images breaking out of content area #257 --- wp-blocks/image.css | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/wp-blocks/image.css b/wp-blocks/image.css index 6cdffa37..36597ca6 100644 --- a/wp-blocks/image.css +++ b/wp-blocks/image.css @@ -3,3 +3,11 @@ font-size: var(--wp--preset--font-size--small); color: var(--ucsc-dark-gray); } + +body .is-layout-constrained > .alignleft { + margin-left: calc((100% - var(--wp--style--global--content-size)) / 2) !important; +} + +body .is-layout-constrained > .alignright { + margin-right: calc((100% - var(--wp--style--global--content-size)) / 2) !important; +} From b08334d098753c56bcf9933ba4f7fa3b05ea7b28 Mon Sep 17 00:00:00 2001 From: Jason Chafin Date: Fri, 13 Oct 2023 10:56:55 -0700 Subject: [PATCH 2/2] refactor: :art: Move float fix CSS from `images.css` to `_alignments.scss` for global use. --- src/scss/base/_alignments.scss | 18 +++++++----------- src/scss/style.scss | 1 + wp-blocks/image.css | 7 ------- 3 files changed, 8 insertions(+), 18 deletions(-) diff --git a/src/scss/base/_alignments.scss b/src/scss/base/_alignments.scss index 2b9fa3b0..6ae8defa 100644 --- a/src/scss/base/_alignments.scss +++ b/src/scss/base/_alignments.scss @@ -1,18 +1,14 @@ /*-------------------------------------------------------------- # - Alignments --------------------------------------------------------------*/ -.alignleft { - float: left; - clear: left; -} -.alignright { - float: right; - clear: right; +/* + * Fix WP bug that pushes left and rigtht floats outside bounding box + */ +.is-layout-constrained > .alignleft { + margin-left: calc((100% - var(--wp--style--global--content-size)) / 2) !important; } -.aligncenter { - clear: both; - display: table; +.is-layout-constrained > .alignright { + margin-right: calc((100% - var(--wp--style--global--content-size)) / 2) !important; } - diff --git a/src/scss/style.scss b/src/scss/style.scss index 37d8ab09..e8a34fcd 100644 --- a/src/scss/style.scss +++ b/src/scss/style.scss @@ -8,6 +8,7 @@ @import "base/normalize"; @import "base/svg"; @import "base/layout"; +@import "base/alignments"; // Theme //=============================== diff --git a/wp-blocks/image.css b/wp-blocks/image.css index 36597ca6..493d6259 100644 --- a/wp-blocks/image.css +++ b/wp-blocks/image.css @@ -4,10 +4,3 @@ color: var(--ucsc-dark-gray); } -body .is-layout-constrained > .alignleft { - margin-left: calc((100% - var(--wp--style--global--content-size)) / 2) !important; -} - -body .is-layout-constrained > .alignright { - margin-right: calc((100% - var(--wp--style--global--content-size)) / 2) !important; -}