Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If I include code, I cannot cancel the style I set earlier (such as bold). #1388

Closed
akirarika opened this issue May 28, 2021 · 5 comments
Closed

If I include code, I cannot cancel the style I set earlier (such as bold). #1388

akirarika opened this issue May 28, 2021 · 5 comments
Assignees
@philippkuehn
Labels
Type: Bug The issue or pullrequest is related to a bug

Comments

@akirarika
Copy link
Contributor

Description
Thank you for creating this great editor framework! I have a problem. I don't know if it is a bug:

Screenshot, video, or GIF
录屏_选择区域_20210528152800

Steps to reproduce the bug
Steps to reproduce the behavior:

  1. Open Tiptap Demo
  2. Set a piece of text as code
  3. Click bold (or italic, strike..)
  4. Click again
  5. Style not cancelled as expected

Environment?

  • operating system: Debian10
  • browser: Chrome v90
  • mobile/desktop: Desktop
  • tiptap version: Latest
@akirarika akirarika added Type: Bug The issue or pullrequest is related to a bug v2 labels May 28, 2021
@akirarika akirarika changed the title If there is code, you cannot ungyle (such as bold). If there is code, then cannot ungyle (such as bold). May 28, 2021
@akirarika akirarika changed the title If there is code, then cannot ungyle (such as bold). If you include code, I cannot cancel the style I set earlier (such as bold). May 28, 2021
@akirarika akirarika changed the title If you include code, I cannot cancel the style I set earlier (such as bold). If I include code, I cannot cancel the style I set earlier (such as bold). May 28, 2021
@philippkuehn
Copy link
Contributor

hey, can you reproduce this on another operating system/browser too?

@akirarika
Copy link
Contributor Author

akirarika commented May 29, 2021 •
edited
Loading

This is recorded in the Chrome v90 under Windows10 20H2:

QQ.20210529125254.mp4

This is Chrome v91 under Android 10:

Screenrecorder-2021-05-29-12-55-41-955.mp4

@philippkuehn Sorry, I don't have Apple-related devices around me, I can only provide Linux, Windows and Android videos 😥

@akirarika
Copy link
Contributor Author

akirarika commented May 29, 2021 •
edited
Loading

It seems that there will be the same problem on Firefox:

_._20210529130957.mp4

The Firefox version is 82

@philippkuehn
Copy link
Contributor

ah, this only happens if there is a code mark within the selection.

@akirarika
Copy link
Contributor Author

ah, this only happens if there is a code mark within the selection.

Yes😥. Sorry, my native language is not English, before may not have described clearly

@philippkuehn philippkuehn self-assigned this May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philippkuehn philippkuehn

Labels
Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@philippkuehn @akirarika