Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus jump after checking off a task item #2172

Closed
1 of 2 tasks
codemzy opened this issue Nov 18, 2021 · 1 comment
Closed
1 of 2 tasks

Focus jump after checking off a task item #2172

codemzy opened this issue Nov 18, 2021 · 1 comment
Labels
Type: Bug The issue or pullrequest is related to a bug

Comments

@codemzy
Copy link
Contributor

codemzy commented Nov 18, 2021

What’s the bug you are facing?

If you have a really long task list, and you load up the editor, scroll down a long way, and check off an item, the editor jumps back up to the top.

How can we reproduce the bug on our side?

Yes, if you create a long task list here https://tiptap.dev/examples/tasks so the top item is out of view, then focus on the top item, scroll down to the bottom item and check it, the editor will jump back up to the top.

Can you provide a CodeSandbox?

Can see behaviour here https://tiptap.dev/examples/tasks

What did you expect to happen?

I expect the checkbox to stay in view in case I want to toggle it again and so I don't lose my place.

Anything to add? (optional)

I wondered if removing the focus command in the chain on line 121 here would resolve the issue without having any negative impact? Or instead of just putting focus back on to the editor, could the focus be put on to the text of the task item you have checked.

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@codemzy codemzy added the Type: Bug The issue or pullrequest is related to a bug label Nov 18, 2021
@codemzy
Copy link
Contributor Author

codemzy commented Nov 25, 2021

Awesome thanks! Tiptap is amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Development

No branches or pull requests

1 participant