Floating menu shows when editor.isEditable == false

[nitipit]

What’s the bug you are facing?

Floating menu shows when editor.isEditable == false

Which browser was this experienced in? Are any special extensions installed?

Google Chrome v100

How can we reproduce the bug on our side?

Call editor.setEditable(false) then click on empty content, then the floating-menu will show up.

Can you provide a CodeSandbox?

Condition check here in public shouldShow

tiptap/packages/extension-floating-menu/src/floating-menu-plugin.ts

Line 44 in c9eb6a6

if (

Should add || !editor.isEditable

if (
    !view.hasFocus()
    || !empty
    || !isRootDepth
    || !isEmptyTextBlock
    || !editor.isEditable  // <- Add this line.
)

What did you expect to happen?

Floating menu should not show when editor.isEditable == false

Anything to add? (optional)

No response

Did you update your dependencies?

• Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

• Yes, I’m a sponsor. 💖

[AlonBru]

If you need an urgent fix, try removing the suggestion props, this seems to be rid of the menu

 Mention.configure( {
  HTMLAttributes: {
    class: 'mention',
   },
} )

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[nitipit]

Hi, is anyone here ?
The fixing code I've provided is straight forward, I can make a pull request if the maintainer of the project agree.

[github-actions]

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days

[bdbch]

Hey @nitipit I'll take a look at this issue asap. Sorry for the long wait time!

[nitipit]

@bdbch Thanks

[Nicolas-Dolan]

@bdbch I'm having a great time with tiptap and appreciate all the hardwork you guys have put into it. Unfortunately this fix has broken a feature in my build. Is there now any way to show the bubble menu if you do want to display it while the editor is not editable? Seems like the kind of feature that would be useful in many situations, not just while editing.

[bdbch]

@Nicolas-Dolan not really - could you create an issue so we can reimplement this as an option?