-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pressing Delete
on an empty paragraph clears the node afterwards
#2924
Comments
Thanks, set the priority to high in our project board! Should definitely be fixed as soon as we get all those typing issues fixed. |
This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days |
@bdbch This issue still exists, do you think this could be reopened, and possibly some attention? |
Hey @rfgamaral I'm looking into it now |
It seems like it's not happening with all nodes. From what I've seen lists and blockquotes are effected, but code blocks and headlines stay the same. |
It also seems like this bug is introduced by Prosemirror as it also happens on their examples site. I created an issue there: ProseMirror/prosemirror#1309 Would be nice if you could bump it. Is it okay for you if we close this issue and hope this problem gets resolved within Prosemirror? I'm not sure if we can intercept that behavior on our side. |
@bdbch Do you think this is something that you'll want to fix on Tiptap, or leave it as-is? The current behaviour is not very common, and I couldn't find any other non ProseMirror based editors that would behave in the same way. IMO, pressing delete should delete the empty paragraph, and not "unwrap the node ahead". |
As it seems this behaviour is intended by marijnh I'd say we should look into it again. Also I think this happens for different types of nodes so we would need to do this handling for everything, right? |
In a way, this is already configurable, by overriding the So, if you want to keep the current behaviour the default, I can work around this on my side (although I'm having some difficulty finding out the right set of commands to run to achieve this). But IMO, a more natural and common behaviour would be to do this built-in
Not exactly sure what you mean, but tweaking the |
What’s the bug you are facing?
This is better explained with a short demo:
Which browser was this experienced in? Are any special extensions installed?
All of them. No special extensions.
How can we reproduce the bug on our side?
Use the default example editor, and replicate what you see in the GIF above.
What did you expect to happen?
Pressing
Delete
on an empty paragraph (orShift + Backspace
on macOS, I believe), should delete the empty paragraph where the text cursor is located (and not clear the node that comes afterwards).Did you update your dependencies?
Are you sponsoring us?
The text was updated successfully, but these errors were encountered: