Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Item In Use responses consistent #89

Open
anjackson opened this issue May 26, 2022 · 3 comments
Open

Make Item In Use responses consistent #89

anjackson opened this issue May 26, 2022 · 3 comments

Comments

@anjackson
Copy link
Contributor

anjackson commented May 26, 2022

Items that are in use (SCU locked) give different errors depending on how they are accessed. Accessed as normal, gives a 200 response that contains, in the replay iframe, this message:

Archived Web Page Locked

The page you have requested is currently in use. Please try again later.

In contrast, accessing the mp_ frame URL directly gives a different page with a 403 response and with the same text but with a header like the calendar pages.

The former should at least respond with the same HTTP status code as the iframe, not a 200.

@anjackson
Copy link
Contributor Author

For this condition, other possible status codes are 409 Conflict or 423 Locked. Using these would make reporting SCU lockouts easier.

@ldbiz
Copy link
Contributor

ldbiz commented Oct 11, 2023

@anjackson before I delve into reproducing this, do you know it still to be an issue? I note the code seems to indicate the message is only shown for 403s:

https://github.com/ukwa/ukwa-pywb/blob/master/templates/error.html#L54

@ldbiz ldbiz added the question Further information is requested label Oct 11, 2023
@anjackson
Copy link
Contributor Author

The issue description was wrong, so I've re-written it. I think this might be a long-standing issue, where the outer frame/banner page does not report the embedded page status. This is related to webrecorder/pywb#549

This is an example page you can try, using the DEV deployment of the Reading Room stack:

http://dev1.n45.wa.bl.uk:8201/en/web/19950418155600/http://portico.bl.uk/

This issue is fairly difficult to test as you need a test configuration that implements page locking. e.g. https://git.wa.bl.uk/ukwa/services/ukwa-npld-access-stack

Having re-read that related issue, it's possible that enabling PyWB's redirect_to_exact option might help.

@ldbiz ldbiz removed the question Further information is requested label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants