-
-
Notifications
You must be signed in to change notification settings - Fork 16.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flask Memory Release Error #7288
Comments
👋 Hello @celalettinbilgen, thank you for your interest in YOLOv5 🚀! Please visit our ⭐️ Tutorials to get started, where you can find quickstart guides for simple tasks like Custom Data Training all the way to advanced concepts like Hyperparameter Evolution. If this is a 🐛 Bug Report, please provide screenshots and minimum viable code to reproduce your issue, otherwise we can not help you. If this is a custom training ❓ Question, please provide as much information as possible, including dataset images, training logs, screenshots, and a public link to online W&B logging if available. For business inquiries or professional support requests please visit https://ultralytics.com or email [email protected]. RequirementsPython>=3.7.0 with all requirements.txt installed including PyTorch>=1.7. To get started: git clone https://github.com/ultralytics/yolov5 # clone
cd yolov5
pip install -r requirements.txt # install EnvironmentsYOLOv5 may be run in any of the following up-to-date verified environments (with all dependencies including CUDA/CUDNN, Python and PyTorch preinstalled):
StatusIf this badge is green, all YOLOv5 GitHub Actions Continuous Integration (CI) tests are currently passing. CI tests verify correct operation of YOLOv5 training (train.py), validation (val.py), inference (detect.py) and export (export.py) on MacOS, Windows, and Ubuntu every 24 hours and on every commit. |
@celalettinbilgen good news 😃! Your original issue may now be fixed ✅ in PR #7289. This PR implements context managers when opening files to properly close them after use. To receive this update:
Thank you for spotting this issue and informing us of the problem. Please let us know if this update resolves the issue for you, and feel free to inform us of any other issues you discover or feature requests that come to mind. Happy trainings with YOLOv5 🚀! |
Thank you @glenn-jocher . Unfortunately, I see that the problem still persists. The problem is in the restapi.py file, not the request script. Memory keeps increasing as I use it :( |
@celalettinbilgen could you try PR #7309 to see if this helps? git clone https://github.com/ultralytics/yolov5 -b update/restapi |
I think this may be related to opening may PIL Images without closing them, per https://pillow.readthedocs.io/en/stable/reference/open_files.html If the PR doesn't work try the alternative implementations in the PIL docs until something works, and then let us know. Thanks! |
official sample not working :( |
@celalettinbilgen got it! Please debug this by editing https://github.com/ultralytics/yolov5/pull/7309/files per https://pillow.readthedocs.io/en/stable/reference/open_files.html to see if you can find a suitable solution. |
@glenn-jocher I understand you very well. However, when I debug, the error I posted above is present. I pulled 7309. |
@celalettinbilgen yes I understand. Please modify the code yourself to see if you can find a suitable solution per https://pillow.readthedocs.io/en/stable/reference/open_files.html, and then please submit a PR. Please see our ✅ Contributing Guide to get started. |
Search before asking
YOLOv5 Component
Detection, Integrations, Other
Bug
When using a flask, the memory is constantly increasing. I add the memory usage in the image below. I am using official Flask example. I see that the memory increases as I use the web service.
Environment
Minimal Reproducible Example
No response
Additional
No response
Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: