Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tRFCb is not applied for BANK_LEVEL_STAGGERED refresh policy #24

Open
channoh opened this issue Sep 30, 2021 · 0 comments
Open

tRFCb is not applied for BANK_LEVEL_STAGGERED refresh policy #24

channoh opened this issue Sep 30, 2021 · 0 comments

Comments

@channoh
Copy link

channoh commented Sep 30, 2021

It seems like tRFCb for BANK_LEVEL_STAGGERED refresh policy is not applied. Timing parameters for it are defined at timing.cc:225, but the one of them, same_rank, is not used at UpdateTiming() in channel_state.cc.

In my opinion, the same_rank at timing.cc:225 should be same_bank. Please confirm it.


Example

  • Config: configs/DDR4_8Gb_x8_3200.ini with BANK_LEVEL_STAGGERED as refresh policy. (tRFCb = 20)
  • Trace
    0x20000000 READ  1950
  • Command trace (vanilla version)
    1950               refresh_bank          -1   0   0   0     -0x1     -0x1
    1952               activate               0   0   0   0    0x800      0x0 ## it should be issued at 1970 (= 1950 + 20)
    1974               read                   0   0   0   0    0x800      0x0
  • Command trace (modifying same_bank to same_rank)
    1950               refresh_bank          -1   0   0   0     -0x1     -0x1
    1970               activate               0   0   0   0    0x800      0x0
    1992               read                   0   0   0   0    0x800      0x0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant