Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

重新挂载子应用报错 「SKIP_BECAUSE_BROKEN」 #2735

Closed
lfzs opened this issue Oct 19, 2023 · 5 comments
Closed

重新挂载子应用报错 「SKIP_BECAUSE_BROKEN」 #2735

lfzs opened this issue Oct 19, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@lfzs
Copy link

lfzs commented Oct 19, 2023

What happens?

1、基座激活 micro-a 应用
2、卸载 micro-a, 激活 micro-b 应用
3、卸载 micro-b,再次激活 micro-a 应用(报错)
image

loadApp.ts:107 Uncaught TypeError: application 'micro-a' died in status SKIP_BECAUSE_BROKEN: Cannot read properties of null (reading 'firstChild')

Mini Showcase Repository(REQUIRED)

可复现仓库:https://github.com/lfzs/qiankun-rc-vite/tree/main

How To Reproduce

查看 README.md 步骤

Context

  • qiankun Version: 3.0.0-rc.5
  • Platform Version: Mac
  • Browser Version: Chrome 版本 118.0.5993.70(正式版本) (x86_64)
@kuitos kuitos added the bug Something isn't working label Oct 19, 2023
@lfzs
Copy link
Author

lfzs commented Oct 23, 2023

@bravepg 您好,请问什么时候能修复呢?

@bravepg
Copy link
Contributor

bravepg commented Oct 23, 2023

image

qiankun 2.0 把节点挂载到了用户指定的节点下,然后做了 gc 和 dom 的重建工作
image

============
image
qiankun 3.0 直接复用了 dom 节点,然后做了 gc。
image

有两种改法:

  1. 跟 2.0 保持一致,将 qiankun 挂载到用户指定的节点,增加 gc 和 dom 重建代码
  2. 保持现有模式,直接移除 gc 代码即可。

个人觉得第一种更合理,你觉得呢 @kuitos

@kuitos
Copy link
Member

kuitos commented Oct 23, 2023

3.0 也是做了重建了
image

看来是这段代码有点 bug

@bravepg
Copy link
Contributor

bravepg commented Oct 25, 2023

3.0.0-rc.9,已经解决

@bravepg bravepg closed this as completed Oct 25, 2023
@kampiu
Copy link

kampiu commented Nov 14, 2024

[email protected] 版本如何处理呢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants