Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mass render does not appear to work #28

Open
xbony2 opened this issue Dec 26, 2020 · 6 comments · May be fixed by #30
Open

Mass render does not appear to work #28

xbony2 opened this issue Dec 26, 2020 · 6 comments · May be fixed by #30

Comments

@xbony2
Copy link
Contributor

xbony2 commented Dec 26, 2020

@pupnewfster Testing with All The Mods 1.16.4 + HuesoDeWiki + BlockRenderer. Rendering a single block/item seems fine, but CTRL + ` only dumps a single item with no GUI popping up. CMD + ` does nothing. I never remember what uses CMD and what uses CTRL but I'm guessing CMD + ` should bring up the GUI since it's the one not doing anything (in comparison, trying CTRL, ALT, or say G + ` dumps the single render).

Tried a new 1.16.4 (Forge 35.1.13) instance with literally just BlockRenderer, trying to dump vanilla. Same issue.

I'm on Mac if that matters.

@pupnewfster
Copy link
Contributor

pupnewfster commented Dec 26, 2020

Worked fine for me when I tested it before making the PR, maybe @unascribed 's refactoring broke it, no idea I haven't tested it since I submitted the PR. Or maybe that is the issue that the person was having on a mac no idea.

@unascribed
Copy link
Owner

I primarily tested with bulk renders, they work as far as I know. Will double-check.

@unascribed
Copy link
Owner

By the way, I suddenly realized the other day what the Mac issue is: usage of BufferedImage. You can't initialize the AWT toolkit on 1.14+ due to its usage of GLFW.

@unascribed
Copy link
Owner

Bulk render is working for me.

@AterAnimAvis
Copy link

AterAnimAvis commented Dec 26, 2020

@xbony2 It would be interesting to see if running with -Djava.awt.headless=true would mitigate/fix this for you.

Actually looking through deobf'd, it looks like Mojang are programatically setting this already in Main since at least 1.15.2. 🤷‍♂️ Unfortunately I haven't got a Mac so I can't diagnose this more, but from what I can find headless AWT should of fixed the major issue with Mac (GLFW and AWT event loops cannot run at the same time in the main/first thread on macOS).

@xbony2
Copy link
Contributor Author

xbony2 commented Dec 27, 2020

Well unfortunately my mac today just bit the bullet so I can't test it. I'm suspecting/hoping it's an issue with just the graphics card which no longer spins when the computer turns on. I use Time Machine (automatically backs up stuff often) and all my projects are saved on GitHub or otherwise online, and I think the storage is probably fine anyway, but certainly a pain nevertheless... 😒

edit: seems my mac is working again for now. No idea what happened. I will try to test this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants