Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit should be pushed before creating tag #18

Open
sdankel opened this issue Jan 27, 2023 · 1 comment
Open

Commit should be pushed before creating tag #18

sdankel opened this issue Jan 27, 2023 · 1 comment

Comments

@sdankel
Copy link

sdankel commented Jan 27, 2023

First of all, thank you for creating this! I love the idea of bundling all of this boilerplate activity into an easy-to-use action.

My expectation is that the version bump in package.json and generated release notes should be included in the released version. However, it doesn't appear to be working that way. For example, in the last release of this project:

1.3.1...1.4.0

You can see that it includes the release notes and version bump from the previous release, rather than from 1.4.0. Looking at the code, I can see this is because the tag is created and pushed before the commit is made. I see two options:

  1. Move the logic that creates and pushes the tag to after the commit is pushed or
  2. Retag the tag after the commit is pushed to point to the hash of the commit

I prefer option 1 because it means that if the action ever fails to push the commit, there is no need to clean up the tags. Happy to submit a PR for this if this proposal is accepted.

@zomars
Copy link

zomars commented Feb 9, 2023

Agreed with @sdankel this is the only thing preventing us to adopt this into @calcom

EDIT:

Our desired use case is basically:

  1. Trigger the action manually
  2. Bump and commit the package.json version
  3. Create a new tag
  4. Create a new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants