You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all, thank you for creating this! I love the idea of bundling all of this boilerplate activity into an easy-to-use action.
My expectation is that the version bump in package.json and generated release notes should be included in the released version. However, it doesn't appear to be working that way. For example, in the last release of this project:
You can see that it includes the release notes and version bump from the previous release, rather than from 1.4.0. Looking at the code, I can see this is because the tag is created and pushed before the commit is made. I see two options:
Move the logic that creates and pushes the tag to after the commit is pushed or
Retag the tag after the commit is pushed to point to the hash of the commit
I prefer option 1 because it means that if the action ever fails to push the commit, there is no need to clean up the tags. Happy to submit a PR for this if this proposal is accepted.
The text was updated successfully, but these errors were encountered:
First of all, thank you for creating this! I love the idea of bundling all of this boilerplate activity into an easy-to-use action.
My expectation is that the version bump in package.json and generated release notes should be included in the released version. However, it doesn't appear to be working that way. For example, in the last release of this project:
1.3.1...1.4.0
You can see that it includes the release notes and version bump from the previous release, rather than from 1.4.0. Looking at the code, I can see this is because the tag is created and pushed before the commit is made. I see two options:
I prefer option 1 because it means that if the action ever fails to push the commit, there is no need to clean up the tags. Happy to submit a PR for this if this proposal is accepted.
The text was updated successfully, but these errors were encountered: