Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder command sequence documented in contributing instructions #1

Open
cyberladysj opened this issue May 22, 2019 · 2 comments
Open

Reorder command sequence documented in contributing instructions #1

cyberladysj opened this issue May 22, 2019 · 2 comments
Labels
status: easy easy issue that is friendly to new contributor type: docs documentation improvement, missing or needing clarification
Milestone
0.1.1-rc.1

Comments

@cyberladysj
Copy link

  • Reversing install procedure: Poetry should be installed first and then pre-commint would follow.
    "git clone https://github.com/undp/seleniumprobes.git SeleniumProbes
    cd SeleniumProbes
    pre-commit install
    poetry install"

  • Include "pyenve" installation in ~/.bashrc, verifying virtual environment persistent installation.
@OK-UNDP OK-UNDP added status: easy easy issue that is friendly to new contributor type: docs documentation improvement, missing or needing clarification labels May 23, 2019
@OK-UNDP
Copy link
Contributor

OK-UNDP commented May 23, 2019

@cyberladysj, thanks for spotting the doc error!

Also, the third step of the Managing Virtual Environments section of CONTRIBUTING.md mentions that .bashrc should be edited for pyenv to engage automatically. So, does this address your second bullet point or you meant something else?

@OK-UNDP OK-UNDP added this to the 0.1.1-rc.1 milestone May 23, 2019
@OK-UNDP OK-UNDP changed the title Doc: Some things to fix Reorder command sequence documented in contributing instructions May 23, 2019
@cyberladysj
Copy link
Author

Yes, editing .bashrc for pyenve to engage automatically addresses my second bullet point. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: easy easy issue that is friendly to new contributor type: docs documentation improvement, missing or needing clarification
Projects
None yet
Milestone
0.1.1-rc.1
Development

No branches or pull requests
2 participants
@cyberladysj @OK-UNDP