Releases not appearing on repos #183

mondele · 2017-05-22T17:02:37Z

Description

As a site admin, I want to be able to create a release for an end-user on one of their repos. What is currently happening is that if I do so, the releases page doesn't load.

Examples:

Screenshots

Screenshot wouldn't be useful. The page doesn't load. (Not even enough html to show page source.)

ethantkoenig · 2017-06-02T01:46:57Z

I'm unable to reproduce this locally. Could someone provide a log?

ethantkoenig · 2017-06-02T01:54:50Z

Or better yet, could someone teach me how/where to view production logs?

mondele · 2017-06-02T02:02:04Z

I'm not sure what kind of log I could create. Here's what's displayed when I load the page in Opera in Centos 7: This page isn't working - git.door43.org is currently unable to handle this request.

This is the result for both links above. In Safari I just get a blank page. Brave browser indicates a 500 error.

ethantkoenig · 2017-06-02T02:14:16Z

@mondele No, I mean the logs that gitea/gogs/DCS automatically generates, not any sort of log you would create manually.

mondele · 2017-06-02T02:27:09Z

Okay, that I will need to leave to your team. :-)

richmahn · 2017-06-02T08:26:06Z

@ethantkoenig If @jag3773 gives you access to the aws server you can see them. Here's what I see when tailing the log and going to the release page:

[Macaron] PANIC: runtime error: slice bounds out of range
/usr/local/go/src/runtime/panic.go:489 (0x42c42f)
/usr/local/go/src/runtime/panic.go:35 (0x42b11e)
/tmp/go-muQC/src/code.gitea.io/gitea/vendor/code.gitea.io/git/repo_tag.go:136 (0x7ea426)
/tmp/go-muQC/src/code.gitea.io/gitea/vendor/code.gitea.io/git/repo_tag.go:164 (0x7ea716)
/tmp/go-muQC/src/code.gitea.io/gitea/routers/repo/release.go:70 (0xe3f8f4)
/usr/local/go/src/runtime/asm_amd64.s:514 (0x4592f8)
/usr/local/go/src/reflect/value.go:434 (0x4bba9f)
/usr/local/go/src/reflect/value.go:302 (0x4bb064)
/tmp/go-muQC/src/code.gitea.io/gitea/vendor/github.com/go-macaron/inject/inject.go:177 (0x8566bf)
/tmp/go-muQC/src/code.gitea.io/gitea/vendor/github.com/go-macaron/inject/inject.go:137 (0x85608a)
/tmp/go-muQC/src/code.gitea.io/gitea/vendor/gopkg.in/macaron.v1/context.go:113 (0x883382)
/tmp/go-muQC/src/code.gitea.io/gitea/vendor/gopkg.in/macaron.v1/context.go:104 (0x8832a6)
/tmp/go-muQC/src/code.gitea.io/gitea/vendor/github.com/go-macaron/session/session.go:186 (0x8da9e0)
/usr/local/go/src/runtime/asm_amd64.s:514 (0x4592f8)
/usr/local/go/src/reflect/value.go:434 (0x4bba9f)
/usr/local/go/src/reflect/value.go:302 (0x4bb064)
/tmp/go-muQC/src/code.gitea.io/gitea/vendor/github.com/go-macaron/inject/inject.go:177 (0x8566bf)
/tmp/go-muQC/src/code.gitea.io/gitea/vendor/github.com/go-macaron/inject/inject.go:137 (0x85608a)
/tmp/go-muQC/src/code.gitea.io/gitea/vendor/gopkg.in/macaron.v1/context.go:113 (0x883382)
/tmp/go-muQC/src/code.gitea.io/gitea/vendor/gopkg.in/macaron.v1/context.go:104 (0x8832a6)
/tmp/go-muQC/src/code.gitea.io/gitea/vendor/gopkg.in/macaron.v1/recovery.go:161 (0x89640b)
/usr/local/go/src/runtime/asm_amd64.s:514 (0x4592f8)
/usr/local/go/src/reflect/value.go:434 (0x4bba9f)
/usr/local/go/src/reflect/value.go:302 (0x4bb064)
/tmp/go-muQC/src/code.gitea.io/gitea/vendor/github.com/go-macaron/inject/inject.go:177 (0x8566bf)
/tmp/go-muQC/src/code.gitea.io/gitea/vendor/github.com/go-macaron/inject/inject.go:137 (0x85608a)
/tmp/go-muQC/src/code.gitea.io/gitea/vendor/gopkg.in/macaron.v1/context.go:113 (0x883382)
/tmp/go-muQC/src/code.gitea.io/gitea/vendor/gopkg.in/macaron.v1/router.go:184 (0x8976d9)
/tmp/go-muQC/src/code.gitea.io/gitea/vendor/gopkg.in/macaron.v1/router.go:288 (0x88f7bd)
/tmp/go-muQC/src/code.gitea.io/gitea/vendor/gopkg.in/macaron.v1/macaron.go:177 (0x8877ec)
/tmp/go-muQC/src/code.gitea.io/gitea/vendor/github.com/gorilla/context/context.go:141 (0xab268b)
/usr/local/go/src/net/http/server.go:1942 (0x6d3894)
/usr/local/go/src/net/http/server.go:2568 (0x6d6152)
/usr/local/go/src/net/http/server.go:1825 (0x6d2402)
/usr/local/go/src/runtime/asm_amd64.s:2197 (0x45bab1)

richmahn · 2017-06-02T08:51:44Z

Also, from the release table for https://git.door43.org/parfait-ayanou/pem-x-gipendegu_jas_text_reg/releases:

mysql> select * from `release` where repo_id = 10321;
+-----+---------+--------------+------------+----------------+--------+-----------------+------------------------------------------+-------------+----------------------------------------------------------------------------------------------------+----------+---------------+--------------+
| id  | repo_id | publisher_id | tag_name   | lower_tag_name | target | title           | sha1                                     | num_commits | note
                                                                            | is_draft | is_prerelease | created_unix |
+-----+---------+--------------+------------+----------------+--------+-----------------+------------------------------------------+-------------+----------------------------------------------------------------------------------------------------+----------+---------------+--------------+
| 135 |   10321 |         4254 | Level1     | level1         | master | Level 1         | a6e07e9bfdcb4a5ad3394a3532797836bcb492a1 |         194 | Kinshasa MAST avril 2017
Source text: ULB-fr https://git.door43.org/parfait-ayanou/fr_mat_jas_ulb |        0 |             0 |   1495459642 |
| 136 |   10321 |         4254 | Level1-bis | level1-bis     | master | Level 1 Release | a6e07e9bfdcb4a5ad3394a3532797836bcb492a1 |         194 | Kinshasa MAST avril 2017
source: ULB français (en voie de vérification au niveau 3)               |        0 |             0 |   1495460103 |
+-----+---------+--------------+------------+----------------+--------+-----------------+------------------------------------------+-------------+----------------------------------------------------------------------------------------------------+----------+---------------+--------------+```

richmahn · 2017-06-02T09:28:54Z

Lastly, looking at line 154 of repo_tag.go in code.gitea.io/git, I did my own git command line it does to get the tags:

[root@ip-172-31-38-86 pem-x-gipendegu_jas_text_reg.git]# git log --tags --simplify-by-decoration --pretty=format:"%ci %d %H %cn<%ce> %s"
2017-05-09 13:21:21 +0100  (HEAD -> master, tag: Level1-bis, tag: Level1) a6e07e9bfdcb4a5ad3394a3532797836bcb492a1 parfait-ayanou<[email protected]> Tue May 09 2017 13:21:21 GMT+0100 (W. Central Africa Standard Time)
2017-05-04 15:04:21 +0100  b4240b6b4ff06277e0e76fbb792a6ab15eb7b91d root<root@localhost> auto save

I'm guessing this second line is not able to be parsed right? No tag: in it for line 121 in repo_tag.go. Other than that, can't figure out what is going on. "auto save" is something tS does.

ethantkoenig · 2017-06-02T14:39:29Z

Looks like it's a bug in code.gitea.io/git/repo_tag.go, caused by there being a closing paren in the commit message. I'll work on a fix.

mondele · 2017-06-02T14:57:49Z

Is there anything we could change in creating the Release that would avoid this? (Thanks for working on a fix.)

ethantkoenig · 2017-06-02T15:27:30Z

See go-gitea/git#58

richmahn · 2017-06-08T23:19:59Z

@ethantkoenig Yeah, I see this has been fixed in upstream and you even have done some work with releases, but how can we get this fixed in the next release? I tested cherry picking some of these commits, but since other files are changed in other commits, it got pretty hairy. Can you see if we can get May/June commits to fix releases into our fork? https://github.com/go-gitea/gitea/commits/0cf89a83c111fe49a8be48c46873182479260d8e/vendor/code.gitea.io/git

ethantkoenig · 2017-06-08T23:22:56Z

@richmahn Probably easiest just to merge all commits from upstream, I'll take a look

richmahn · 2017-06-10T01:44:18Z

@ethantkoenig Yeah, if you could do that, that would be great. Probably would be easiest and best.

richmahn · 2017-06-10T01:44:45Z

Ah, I guess you did. Thanks. So to note, this has been fixed from changes upstream

richmahn · 2017-06-14T15:09:29Z

@mondele This issue is now fixed on production:

https://git.door43.org/parfait-ayanou/pem-x-gipendegu_jas_text_reg/releases
https://git.door43.org/kwaduo/gaj-x-ymnk_obs_text_obs/releases

jag3773 changed the title ~~Releases not appearing on third-party user's repo~~ Releases not appearing on repos Jun 1, 2017

jag3773 added bug Gogs labels Jun 1, 2017

ethantkoenig closed this as completed Jun 2, 2017

ethantkoenig reopened this Jun 2, 2017

ethantkoenig mentioned this issue Jun 8, 2017

Merge changes from upstream #195

Merged

richmahn added this to the WST Sprint #27 milestone Jun 10, 2017

richmahn assigned ethantkoenig Jun 10, 2017

jag3773 closed this as completed Jun 15, 2017

github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Releases not appearing on repos #183

Releases not appearing on repos #183

mondele commented May 22, 2017 •

edited by jag3773

Loading

ethantkoenig commented Jun 2, 2017

ethantkoenig commented Jun 2, 2017

mondele commented Jun 2, 2017

ethantkoenig commented Jun 2, 2017

mondele commented Jun 2, 2017

richmahn commented Jun 2, 2017 •

edited

Loading

richmahn commented Jun 2, 2017

richmahn commented Jun 2, 2017 •

edited

Loading

ethantkoenig commented Jun 2, 2017 •

edited

Loading

mondele commented Jun 2, 2017

ethantkoenig commented Jun 2, 2017

richmahn commented Jun 8, 2017

ethantkoenig commented Jun 8, 2017

richmahn commented Jun 10, 2017

richmahn commented Jun 10, 2017

richmahn commented Jun 14, 2017

Releases not appearing on repos #183

Releases not appearing on repos #183

Comments

mondele commented May 22, 2017 • edited by jag3773 Loading

Description

Screenshots

ethantkoenig commented Jun 2, 2017

ethantkoenig commented Jun 2, 2017

mondele commented Jun 2, 2017

ethantkoenig commented Jun 2, 2017

mondele commented Jun 2, 2017

richmahn commented Jun 2, 2017 • edited Loading

richmahn commented Jun 2, 2017

richmahn commented Jun 2, 2017 • edited Loading

ethantkoenig commented Jun 2, 2017 • edited Loading

mondele commented Jun 2, 2017

ethantkoenig commented Jun 2, 2017

richmahn commented Jun 8, 2017

ethantkoenig commented Jun 8, 2017

richmahn commented Jun 10, 2017

richmahn commented Jun 10, 2017

richmahn commented Jun 14, 2017

mondele commented May 22, 2017 •

edited by jag3773

Loading

richmahn commented Jun 2, 2017 •

edited

Loading

richmahn commented Jun 2, 2017 •

edited

Loading

ethantkoenig commented Jun 2, 2017 •

edited

Loading