Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reference ranges to show multiple verses in the scripture panes #374

Closed
birchamp opened this issue Mar 27, 2023 · 10 comments · Fixed by unfoldingWord/single-scripture-rcl#42
Assignees

Comments

@birchamp
Copy link

birchamp commented Mar 27, 2023

decouple scripture panes from bible-reference-rcl - the reference in the current tNote takes priority for the scripture reference(s) shown

DoD

Single Scripture RCL will have a styleguidist example that proves it supports reference ranges.

Details:

Lars may have something working this way already.

@birchamp birchamp changed the title Add support to show multiple verses to Bible-reference-rcl Add support for reference ranges to show multiple verses in the scripture panes Mar 27, 2023
@kintsoogi
Copy link
Contributor

What I've found so far...

In production version of gateway edit, it looks like the UST Scripture pane is displaying the verse ranges whenever the rc://*/ta/man/translate/translate-versebridge Support Reference exists.
However, in the development version, the text is shown but the verse range numbers are not.

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented Mar 28, 2023

Notes:

  • in Scripture card the reference is parsed into an array scriptureConfig?.versesForRef that looks like:

Screenshot 2023-03-28 at 6 34 59 AM

  • can change Scripture card to display a vertical array of scripture panes in place of the single scripture pane - one for each array element of scriptureConfig?.versesForRef.

  • for edit support, if you click on a verse it will change currentVerseNum.

@birchamp
Copy link
Author

birchamp commented Mar 28, 2023

@kintsoogi note that, verse spans are multiple verses marked as a single verse in USFM scripture as \v 2-3 followed by the text of the two verses mixed together.

Reference ranges is any reference that refers to more than one verse. Reference ranges don't include any scripture. It's just the reference.

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented Mar 28, 2023

Notes:

* in Scripture card the reference is parsed into an array `scriptureConfig?.versesForRef` that looks like:
Screenshot 2023-03-28 at 6 34 59 AM

@kintsoogi Also there may be and endVerse in the array object if there is a verse span included in the ref range. That will be helpful in fixing the issue you mentioned above.

@PhotoNomad0
Copy link
Contributor

@kintsoogi Sorry - that was incorrect. A verse range will look like this (easier):

Screenshot 2023-03-28 at 7 44 41 AM

@kintsoogi
Copy link
Contributor

Progress so far...
Have a running PoC working for displaying a verse span via tabs. Issues that I need to look into further...

  • Whenever a user edits the text, switching between verses is not working.
  • How to make the UI actually look good

@Joel-C-Johnson
Copy link
Collaborator

test procedure

  • the fixes are in gatewayEdit in v1.2.0 build 9ebcb5b
  • test in unfoldingword org - en - PHP - 1:15
  • open tcCreate production - unfoldingword org - -tN- en - PHP - 1:15
  • edit the first note and change the reference to 1:14-18 and put some Greek words in the quote

screenShot 1
image

  • save the changes
  • open gatewayedit
  • select unfoldingword org - en - PHP - 1: 15 and you should see all the verses from 14 to 18 such as below.
    screenshot 2
    image

@elsylambert

@kintsoogi
Copy link
Contributor

@danielklapp

@elsylambert
Copy link
Contributor

Looks good in v1.2.0 build 9ebcb5b

@danielklapp
Copy link

Looks good with v1.2.0 build 1f1cfb0 QA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants