Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support alignment for multiple verses in SP #385

Closed
PhotoNomad0 opened this issue Mar 28, 2023 · 5 comments · Fixed by unfoldingWord/single-scripture-rcl#49 or #420
Closed

Support alignment for multiple verses in SP #385

PhotoNomad0 opened this issue Mar 28, 2023 · 5 comments · Fixed by unfoldingWord/single-scripture-rcl#49 or #420

Comments

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented Mar 28, 2023

This seems to be mostly implemented, but need UI design for how we implement selecting which verse or verse span in reference range to align. Elsy suggested at one point to have an icon button on Scritpure card title that opens drop down for selecting the verse to align. But Currently GWE uses a pop up dialog for three dot settings. Maybe we could also do a pop up dialog to select which verse to edit if there is more than one in the scripture card.

@PhotoNomad0 PhotoNomad0 changed the title Support edit/alignment for multiple verses in SP Support alignment for multiple verses in SP Apr 16, 2023
@PhotoNomad0
Copy link
Contributor Author

PhotoNomad0 commented Apr 17, 2023

Notes:

  • to put alignment icon on scripture card do (from previous release):
import { RxLink2, RxLinkBreak2 } from 'react-icons/rx'
import { IconButton } from '@mui/material'
  const checkingState = aligned ? 'valid' : 'invalid'
  const titleText = checkingState === 'valid' ? 'Alignment is Valid' : 'Alignment is Invalid'
  const onRenderToolbar = ({ items }) => [
    ...items,
    <IconButton
      className={classes.margin}
      key='checking-button'
      onClick={() => handleAlignmentClick()}
      title={titleText}
      aria-label={titleText}
      style={{ cursor: 'pointer' }}
    >
      {checkingState === 'valid' ? (
        <RxLink2 id='valid_icon' color='#BBB' />
      ) : (
        <RxLinkBreak2 id='invalid_icon' color='#000' />
      )}
    </IconButton>,
  ]
  • in GWE we currently use popup dialogs when user selects the three dot menus. See SettingsCard.js in translation-helps-rcl . It would seem that you could just add multiple buttons here.

@birchamp
Copy link

@birchamp Mock up a solution for picking a verse.

@kintsoogi
Copy link
Contributor

Here is a lil mockup of what I was thinking for the functionality to align ranges in gEdit
https://photos.app.goo.gl/ZUYm7ezo8HcBsfiVA

@danielklapp
Copy link

User can easily select which verse or verse span to align in the pop up dialog. This feature looks good! Tested with v2.0.0 build e6d6a7f QA.

@elsylambert
Copy link
Contributor

v2.0.0 build a2a20c1 QA. Seeing the pop up to select the verse to do the alignment in a Reference range. It works fine. However, there is a bug in the aligner which is written separately in #424 and put in QA fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment