Delete rows from TSV7(TN,TWLs)

[elsylambert]

• click minus to delete a row
• Popup confirmation like it shows in tCC
  

For table view:

[elsylambert]

For tWLs, the delete buttons must delete the highlighted row in the Twls card.

[birchamp]

@jincypjose @theNerd247 @kintsoogi Here are some various screenshots of different UIs for adding and removing rows. The first one (material-ui) is what I was trying to describe yesterday. After that are just a few of the seemingly infinite ways people have done it. I'd recommend whatever is easiest to develop. What's your pick?

1. https://mui.com/material-ui/react-table/
   
2. https://material-table.com/#/docs/features/actions
   
3. Custom modal to Edit/Delete/Add record RXNT/react-json-schema-form-extras#98
   
4. https://stackoverflow.com/questions/51095527/delete-dynamically-added-table-row-react-js
   
5. https://www.youtube.com/watch?v=MINQoCSBmds
   

[theNerd247]

I really like (2). The icons are self explanatory and as someone who reads left to right it flows well.

[theNerd247]

(1) is great if the number of actions per row is >= 3 (as the icons would take up to much real-estate)

[kintsoogi]

Yeah I personally like 1 the best, it just depends on how easy adding the select is!

[jincypjose]

I too liked 1 and 2 both makes sense.

[birchamp]

We will do #3 and put both add and delete button in an actions column. This will make the icons match tCC and it will allow for quick actions for single rows which is most common. The top description has been updated.

[PhotoNomad0]

@elsylambert @danielklapp This issue is in the latest GWE develop build v2.1.0 build f85dc07

[kintsoogi]

@elsylambert @danielklapp

Test Instructions

• Verify that delete buttons exist in the headers of TN & TQ
• Verify that delete buttons exist for each row item for TWL
• Click on the a delete button in either TN, TQ, or TWL and verify that a Delete TSV Dialog appears
  • Verify that this dialog shows the information of the TSV item that you selected to delete
• Click the 'delete' button on the dialog
  • Verify that the item no longer exists within the resource
• Open console and see "new Quote" console log when clicking on any TWL item
  • Verify that this console log is not being fired off twice for each click (Functionality of pure setItemIndex)
  • Open either the add or delete row Item dialog and verify that the same console log does not fire when clicking in the dialog

[elsylambert]

Verified in v2.1.0 build f85dc07 QA

• Delete button is available in tN card, TWL rows and tQ card.
• On clicking delete, the pop-up brings the active row in tN and tQ and for twl, it brings up the row item where we clicked delete.
• Delete button, deletes the record from the tsv resource.

Works as expected.

[elsylambert]

Private Zenhub Image

[danielklapp]

Verified everything listed on the test instructions. Looks good to me and tested with v2.1.0 build f85dc07 QA.

[PhotoNomad0]

@elsylambert @danielklapp I was able to reproduce the problem I saw before:

tN-AddError-x0.5.mov

[PhotoNomad0]

@kintsoogi - It seems related to adding the tN to the end of the book. It's throwing an exception.

[elsylambert]

Moved the bug to #592