Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing in scripture lags when the verse is long #526

Closed
birchamp opened this issue Aug 10, 2023 · 4 comments
Closed

Typing in scripture lags when the verse is long #526

birchamp opened this issue Aug 10, 2023 · 4 comments

Comments

@birchamp
Copy link

Per Steven Wunrow, typing in the scripture window lags when there are more than ~50 words and many changes.

DoD

Typing remains normal after completely changing a 50 word verse.

@PhotoNomad0
Copy link
Contributor

@elsylambert OK, I was able to reproduce. Investigating.

@PhotoNomad0
Copy link
Contributor

@elsylambert @danielklapp The fix is in GWE develop v2.3.0 build 0eda053

@elsylambert
Copy link
Contributor

Verified in v2.3.0 build 0eda053 QA. Not seeing lag in typing when we have a big chunk of text typed into the verse. It shows a spinner OnBlur, after the edit is done and then Save button is enabled. When the spinner is running, the action buttons on the card are disabled which is intentional to avoid clicks when the system is validating the alignments. Works ars expected.

@danielklapp
Copy link

Agree that there’s no lag when typing in large verses and after an edit is complete a spinner appears letting user know something is happening. Action buttons are working as expected. Tested with v2.3.0 build 0eda053 QA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants