Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TSV to Next Index and Navigate There #544

Closed
kintsoogi opened this issue Sep 14, 2023 · 3 comments
Closed

Add TSV to Next Index and Navigate There #544

kintsoogi opened this issue Sep 14, 2023 · 3 comments

Comments

@kintsoogi
Copy link
Contributor

No description provided.

@kintsoogi
Copy link
Contributor Author

Describe what your issue addresses

  • Do not try to generate TSVs if Resource Card is not a TSV Resource
  • Navigate to new TSV Row on add

Test Instructions

  • using https://deploy-preview-571--gateway-edit.netlify.app/
  • Navigate to front matter and make sure that app does not crash (should have no TSVs)
  • Add a row to either tN, twl, or TQ. Make sure resource added is in the same verse
    • Verify that the added TSV exists within the resource
      • Verify that you are now navigated to the newly created row

@elsylambert
Copy link
Contributor

elsylambert commented Nov 16, 2023

Verified in v2.1.0 build f845565 QA. TN and TQ navigation works fine, Twl does not:

  • Navigate to front matter and make sure that app does not crash (should have no TSVs)

  • Add a row to either tN. Make sure resource added is in the same verse

    • Verify that the added TSV exists within the resource
      • Verify that you are now navigated to the newly created row
  • Add a row to twl. Make sure resource added is in the same verse

    • Verify that the added TSV exists within the resource
      • Verify that you are now navigated to the newly created row
  • Add a row to TQ. Make sure resource added is in the same verse

    • Verify that the added TSV exists within the resource
      • Verify that you are now navigated to the newly created row

To be retested after #542 is fixed.

@elsylambert elsylambert added the Blocked Something is blocked label Nov 16, 2023
@danielklapp
Copy link

danielklapp commented Nov 17, 2023

Tested with v2.1.0 build 65fd995 QA.

  • Navigate to front matter and make sure that app does not crash (should have no TSVs)
  • Add a row to either tN, twl, or TQ. Make sure resource added is in the same verse
  • Verify that the added TSV exists within the resource
  • Verify that you are now navigated to the newly created row

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants