Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference Range Capability for Add TWL #545

Closed
kintsoogi opened this issue Sep 14, 2023 · 4 comments
Closed

Reference Range Capability for Add TWL #545

kintsoogi opened this issue Sep 14, 2023 · 4 comments

Comments

@kintsoogi
Copy link
Contributor

kintsoogi commented Sep 14, 2023

The user should be able to edit the reference field during the add process to any allowable reference - both single references and reference ranges

DoD

Adding a row with a reference range functions as a single reference does.

@birchamp birchamp changed the title Reference Range Capability for Add TSV Reference Range Capability for Add TWL Nov 27, 2023
@birchamp
Copy link

Seems to be working in TN

@kintsoogi
Copy link
Contributor Author

When we add a TSV in a resource, we then immediately reload that TSV resource. During this reload, the fetching function will take the newly created Reference range and propagate it to all references within our book.

All that being said, adding a reference range should already be working! We have some checks when adding to make sure input reference is valid, but this check also accounts for valid reference ranges!

@kintsoogi
Copy link
Contributor Author

To Test

  • Add a new tsv resource (such as tn) including a reference range (try both type 1:1-3 AND 1:3;2:6)
  • After adding the new tsv item, navigate to another verse of the reference range you added! For example, if you input the range 1:3;2:6 and you were at 1:3, then navigate to 2:6
  • Verify that the new tsv item you created exists when you navigate to this reference

@danielklapp
Copy link

Scripture card shows both types of reference ranges. When navigating to either reference, the tsv item is there. Tested with v2.3.0 build bd4a646 QA

Screenshot 2023-12-20 at 12 40 52 AM Screenshot 2023-12-20 at 12 41 58 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants