Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Original language word lost when one word is split from a group of words #643

Closed
elsylambert opened this issue Apr 10, 2024 · 16 comments
Closed
Assignees
Labels
bug Something isn't working Priority/Medium Medium Priority issue QA/DanielTested QA/ElsyTested

Comments

@elsylambert
Copy link
Contributor

When splitting original words, one of the original words gets lost.

Bug_Alignment_Splitting_Orignal_Words.gif

@elsylambert elsylambert added bug Something isn't working Priority/Medium Medium Priority issue labels May 7, 2024
@elsylambert
Copy link
Contributor Author

@PhotoNomad0 here is the issue for Aligner bug where a word is lost when split from a group of words.

@PhotoNomad0
Copy link
Contributor

@elsylambert Do you have an example for this?

@elsylambert
Copy link
Contributor Author

@PhotoNomad0 In es-419_gl org and lang as es-419, go to Jonah 1:1 in Texto Puente Literal, open aligner.
In Jonah 1:1 we have a word that is merged, it is "La palabra de Jehová" it is aligned with two Hebrew words, when we try to split those two Hebrew words to realign them one of those two Hebrew words disappears and we are not able to align it.

@PhotoNomad0
Copy link
Contributor

@elsylambert @danielklapp This should be fixed in v2.4.0 build e1d5248

@elsylambert
Copy link
Contributor Author

elsylambert commented May 16, 2024

@PhotoNomad0 Not seeing loss of Hebrew word when splitting from a group of words, but after making changes, click on Accept and saving it on the card, seeing this error:
Screenshot 2024-05-16 at 8.49.33 AM.png

Private Zenhub Video

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented May 16, 2024 via email

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented May 17, 2024

@elsylambert I can't open your private Zenhub image and videos - tried following your steps, but am not seeing a problem. Using QA server, tit 1:1 en_ust unfoldingWord.

Also tried the Jon 1:1. es literal and not seeing a problem.

@PhotoNomad0 PhotoNomad0 added the Blocked Something is blocked label May 17, 2024
@elsylambert
Copy link
Contributor Author

Private Zenhub Video

@elsylambert
Copy link
Contributor Author

@PhotoNomad0 Please check now if the screenshots and video is visible for you?^^

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented May 20, 2024

@PhotoNomad0 Please check now if the screenshots and video is visible for you?^^

@elsylambert OK, I now have permission to see the video, but still not seeing the error when I reproduce the steps. I tried several times. Do you still see the problem? It looks like your content needs updating - could that be related to the problem you see?
Screenshot 2024-05-20 at 8 10 53 AM

@danielklapp
Copy link

@PhotoNomad0, @elsylambert when I reproduce the steps here's my findings
v2.4.0 build 5c6dfd8 QA
Don't see the loss of original words when splitting from a group of words, but getting a 409 (Conflict) error after clicking on Accept and saving it to the card. A weird thing happens when trying to merge my work. I can check the Mergeable Resources but can't leave a comment in the description box. Looking at the console it's giving a RangeError: Maximum call stack size exceeded.

Screenshot 2024-05-20 at 12 10 55 PM Here's my console history if it helps

deploy-preview-648--gateway-edit.netlify.app-1716221161445.log

@elsylambert
Copy link
Contributor Author

Retested in v2.4.0 build 4b01301 QA this morning with a fresh branch and not seeing Network error. @PhotoNomad0

@elsylambert elsylambert removed QA/Fail Blocked Something is blocked labels May 21, 2024
@elsylambert
Copy link
Contributor Author

@danielklapp Can you retest with a fresh user branch? if the issue still exist, please write a new separate issue for that.

@danielklapp
Copy link

@elsylambert Retested with a fresh branch and issue still persist, will write up a separate issue for it.

@PhotoNomad0
Copy link
Contributor

@PhotoNomad0, @elsylambert when I reproduce the steps here's my findings v2.4.0 build 5c6dfd8 QA Don't see the loss of original words when splitting from a group of words, but getting a 409 (Conflict) error after clicking on Accept and saving it to the card. A weird thing happens when trying to merge my work. I can check the Mergeable Resources but can't leave a comment in the description box. Looking at the console it's giving a RangeError: Maximum call stack size exceeded.
Screenshot 2024-05-20 at 12 10 55 PM Here's my console history if it helps

deploy-preview-648--gateway-edit.netlify.app-1716221161445.log

@danielklapp Yes, it looks like there is an endless recursive loop going on there causing a memory crash. @kintsoogi

@danielklapp
Copy link

Tested with v2.4.0 build 542041b QA, looks good to me. The issue I wrote up separate is issue #650.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority/Medium Medium Priority issue QA/DanielTested QA/ElsyTested
Projects
None yet
Development

No branches or pull requests

3 participants