#10861 : Added modf in numpy frontend #11680

RakshitKumar04 · 2023-03-03T20:31:46Z

Close #12086

RakshitKumar04 · 2023-03-06T15:04:02Z

Hey, @kurshakuz can you please guide me and help in passing these checks

RakshitKumar04 · 2023-03-06T20:21:23Z

Hey, @kurshakuz I have updated the code, can please review my PR.

RakshitKumar04 · 2023-03-13T19:30:14Z

Close #12086

RakshitKumar04 · 2023-03-14T13:27:56Z

Hey @kurshakuz, Please review the PR.

kurshakuz

Hey! Sorry for a delayed response! I have just checked your implementation and it seems to fail local tests. Can you please resolve below errors, check them locally and let me know once you are done? Thanks!

======================================================================== FAILURES =========================================================================
_____________________________________________ test_numpy_modf[cpu-ivy.functional.backends.numpy-False-False] ______________________________________________

arguments = (), kwargs = {}

    @handle_frontend_test(
        fn_tree="numpy.modf",
>       dtypes_and_x=helpers.dtype_and_values(
            available_dtypes=helpers.get_dtypes("float", "int"),
        ),
        where=np_frontend_helpers.where(),
    )
E   hypothesis.errors.InvalidArgument: test_numpy_modf() got an unexpected keyword argument 'dtypes_and_x', from `dtypes_and_x=dtype_and_values(available_dtypes=get_dtypes(kind='float', index='int'))` in @given

ivy_tests/test_ivy/test_frontends/test_numpy/test_mathematical_functions/test_trigonometric_functions.py:10: InvalidArgument
______________________________________________ test_numpy_modf[cpu-ivy.functional.backends.jax-False-False] _______________________________________________

arguments = (), kwargs = {}

    @handle_frontend_test(
        fn_tree="numpy.modf",
>       dtypes_and_x=helpers.dtype_and_values(
            available_dtypes=helpers.get_dtypes("float", "int"),
        ),
        where=np_frontend_helpers.where(),
    )
E   hypothesis.errors.InvalidArgument: test_numpy_modf() got an unexpected keyword argument 'dtypes_and_x', from `dtypes_and_x=dtype_and_values(available_dtypes=get_dtypes(kind='float', index='int'))` in @given

ivy_tests/test_ivy/test_frontends/test_numpy/test_mathematical_functions/test_trigonometric_functions.py:10: InvalidArgument
___________________________________________ test_numpy_modf[cpu-ivy.functional.backends.tensorflow-False-False] ___________________________________________

arguments = (), kwargs = {}

    @handle_frontend_test(
        fn_tree="numpy.modf",
>       dtypes_and_x=helpers.dtype_and_values(
            available_dtypes=helpers.get_dtypes("float", "int"),
        ),
        where=np_frontend_helpers.where(),
    )
E   hypothesis.errors.InvalidArgument: test_numpy_modf() got an unexpected keyword argument 'dtypes_and_x', from `dtypes_and_x=dtype_and_values(available_dtypes=get_dtypes(kind='float', index='int'))` in @given

ivy_tests/test_ivy/test_frontends/test_numpy/test_mathematical_functions/test_trigonometric_functions.py:10: InvalidArgument
_____________________________________________ test_numpy_modf[cpu-ivy.functional.backends.torch-False-False] ______________________________________________

arguments = (), kwargs = {}

    @handle_frontend_test(
        fn_tree="numpy.modf",
>       dtypes_and_x=helpers.dtype_and_values(
            available_dtypes=helpers.get_dtypes("float", "int"),
        ),
        where=np_frontend_helpers.where(),
    )
E   hypothesis.errors.InvalidArgument: test_numpy_modf() got an unexpected keyword argument 'dtypes_and_x', from `dtypes_and_x=dtype_and_values(available_dtypes=get_dtypes(kind='float', index='int'))` in @given

ivy_tests/test_ivy/test_frontends/test_numpy/test_mathematical_functions/test_trigonometric_functions.py:10: InvalidArgument
==================================================================== warnings summary =====================================================================
ivy/__init__.py:1164
  /workspaces/ivy/ivy/__init__.py:1164: UserWarning: jax module has been imported while ivy doesn't import it without setting a backend, ignore if that's intended
    warnings.warn(

ivy_tests/test_ivy/helpers/function_testing.py:69: 87 warnings
  /workspaces/ivy/ivy_tests/test_ivy/helpers/function_testing.py:69: DeprecationWarning: `np.bool8` is a deprecated alias for `np.bool_`.  (Deprecated NumPy 1.24)
    import ivy.compiler.compiler as ic

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================================================================= short test summary info =================================================================
FAILED ivy_tests/test_ivy/test_frontends/test_numpy/test_mathematical_functions/test_trigonometric_functions.py::test_numpy_modf[cpu-ivy.functional.backends.numpy-False-False] - hypothesis.errors.InvalidArgument: test_numpy_modf() got an unexpected keyword argument 'dtypes_and_x', from `dtypes_and_x=dtype_and_values(available_...
FAILED ivy_tests/test_ivy/test_frontends/test_numpy/test_mathematical_functions/test_trigonometric_functions.py::test_numpy_modf[cpu-ivy.functional.backends.jax-False-False] - hypothesis.errors.InvalidArgument: test_numpy_modf() got an unexpected keyword argument 'dtypes_and_x', from `dtypes_and_x=dtype_and_values(available_...
FAILED ivy_tests/test_ivy/test_frontends/test_numpy/test_mathematical_functions/test_trigonometric_functions.py::test_numpy_modf[cpu-ivy.functional.backends.tensorflow-False-False] - hypothesis.errors.InvalidArgument: test_numpy_modf() got an unexpected keyword argument 'dtypes_and_x', from `dtypes_and_x=dtype_and_values(available_...
FAILED ivy_tests/test_ivy/test_frontends/test_numpy/test_mathematical_functions/test_trigonometric_functions.py::test_numpy_modf[cpu-ivy.functional.backends.torch-False-False] - hypothesis.errors.InvalidArgument: test_numpy_modf() got an unexpected keyword argument 'dtypes_and_x', from `dtypes_and_x=dtype_and_values(available_...
============================================================= 4 failed, 88 warnings in 1.78s ==============================================================

kurshakuz · 2023-03-16T07:21:13Z

ivy/functional/frontends/numpy/mathematical_functions/trigonometric_functions.py

+@to_ivy_arrays_and_back
+@handle_numpy_casting
+@from_zero_dim_arrays_to_scalar
+def _modf(


Can you please also clarify why do you need that underscore here? Thanks

Suggested change

def _modf(

def modf(

I referred to the ivy frontends docs which state that "In NumPy, add() is categorised under mathematical_functions with a sub-category of arithmetic_operations as shown in the numpy mathematical functions directory. It is important to note that add() is a universal function (ufunc) in NumPy, thus the function is actually an object with instance methods like .at and .reduce, etc. We deal with this in the NumPy frontend by including a ufunc class and initialising it in the init file" so thats why I used _modf.

https://lets-unify.ai/ivy/deep_dive/ivy_frontends.html

RakshitKumar04 · 2023-03-22T17:09:14Z

Hey, @kurshakuz I did some changes and tried to resolve the errors, can u please review it.

kurshakuz

Hello @RakshitKumar04! I have tested your implementation and it is failing the tests. Please make sure it is correct and passes all of the tests, so that I can have a further look.

E               ivy.utils.exceptions.IvyException: Out argument must be an ivy.frontends.numpy.ndarray object

RakshitKumar04 · 2023-03-26T07:39:02Z

Hey, @kurshakuz I tried solving the error, please guide if it fails again

RakshitKumar04 · 2023-03-28T08:41:04Z

Hey, @kurshakuz please review my pr.

kurshakuz

Please fix the following error and run the tests locally to see if your implementation works:

E               ivy.utils.exceptions.IvyException: Out argument must be an ivy.frontends.numpy.ndarray object

RakshitKumar04 · 2023-04-06T16:15:02Z

.

RakshitKumar04 · 2023-04-10T10:08:31Z

Hey, @kurshakuz can you please guide me on resolving these errors. I ran the modf function on my local machine. Out of 5, 1st test case got passed and the other 4 showed the error listed below.

  return self._data.__array_ufunc__(*args, **kwargs)

E AttributeError: 'ArrayImpl' object has no attribute 'array_ufunc'
E Falsifying example: test_numpy_modf(
E dtype_and_x=(['float32'], [array(-1., dtype=float32)]),
E fn_tree='ivy.functional.frontends.numpy.modf',
E test_flags=FrontendFunctionTestFlags(
E num_positional_args=1,
E with_out=False,
E inplace=False,
E as_variable=[False],
E native_arrays=[False],
E generate_frontend_arrays=False,
E ),
E on_device='cpu',
E frontend='numpy',
E )

self.__getattribute__(name)

E AttributeError: 'tensorflow.python.framework.ops.EagerTensor' object has no attribute 'array_ufunc'
E Falsifying example: test_numpy_modf(
E dtype_and_x=(['float32'], [array(-1., dtype=float32)]),
E fn_tree='ivy.functional.frontends.numpy.modf',
E test_flags=FrontendFunctionTestFlags(
E num_positional_args=1,
E with_out=False,
E inplace=False,
E as_variable=[False],
E native_arrays=[False],
E generate_frontend_arrays=False,
E ),
E on_device='cpu',
E frontend='numpy',
E )

  return self._data.__array_ufunc__(*args, **kwargs)

E AttributeError: 'Tensor' object has no attribute 'array_ufunc'
E Falsifying example: test_numpy_modf(
E dtype_and_x=(['float32'], [array(-1., dtype=float32)]),
E fn_tree='ivy.functional.frontends.numpy.modf',
E test_flags=FrontendFunctionTestFlags(
E num_positional_args=1,
E with_out=False,
E inplace=False,
E as_variable=[False],
E native_arrays=[False],
E generate_frontend_arrays=False,
E ),
E on_device='cpu',
E frontend='numpy',
E )

  return self._data.__array_ufunc__(*args, **kwargs)

E TypeError: 'NoneType' object is not callable
E Falsifying example: test_numpy_modf(
E dtype_and_x=(['float32'], [array(-1., dtype=float32)]),
E fn_tree='ivy.functional.frontends.numpy.modf',
E test_flags=FrontendFunctionTestFlags(
E num_positional_args=1,
E with_out=False,
E inplace=False,
E as_variable=[False],
E native_arrays=[False],
E generate_frontend_arrays=False,
E ),
E on_device='cpu',
E frontend='numpy',
E )

kurshakuz · 2023-04-12T15:06:43Z

@RakshitKumar04 I have not seen this error previously as well. I would suggest to address that issue in one of the Discord channels, maybe some has experience of dealing with that error. Can you do that?

RakshitKumar04 · 2023-04-13T06:44:26Z

@kurshakuz Yes Sir, I will do that.

RakshitKumar04 · 2023-04-22T16:32:07Z

>       assert ret_dtype == ret_from_gt_dtype, (
            "the ground truth framework {} returned a {} datatype while "
            "the backend {} returned a {} datatype".format(
                ground_truth_backend,
                ret_from_gt_dtype,
                ivy.current_backend_str(),
                ret_dtype,
            )
        )
E       AssertionError: the ground truth framework numpy returned a float16 datatype while the backend numpy returned a uint8 datatype
E       Falsifying example: test_numpy_modf(
E           dtypes_values_casting=(['uint8'], [array(1, dtype=uint8)], 'no', None),
E           where=[array(False)],

Hey @kurshakuz how do I resolve this error?

fnhirwa · 2023-04-24T05:31:46Z

Hey @RakshitKumar04 and @kurshakuz

It seems like is the casting issue that is on our testing side 😁
I am fixing that and I think we can merge this PR.

ivy-leaves added the NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist label Mar 3, 2023

ivy-seed assigned kurshakuz Mar 3, 2023

vedpatwardhan force-pushed the master branch from 93a8ff2 to d42a654 Compare March 6, 2023 06:37

RakshitKumar04 force-pushed the modf-ivy-patch2 branch 2 times, most recently from 9da2a6e to ca2fd08 Compare March 6, 2023 14:38

RakshitKumar04 mentioned this pull request Mar 9, 2023

modf #12086

Closed

kurshakuz suggested changes Mar 16, 2023

View reviewed changes

kurshakuz reviewed Mar 16, 2023

View reviewed changes

vedpatwardhan force-pushed the master branch from 78b32d3 to 2f6dd61 Compare March 19, 2023 17:03

vedpatwardhan requested review from CatB1t and vedpatwardhan as code owners March 19, 2023 17:03

RakshitKumar04 closed this Mar 21, 2023

RakshitKumar04 force-pushed the modf-ivy-patch2 branch from 2dec676 to 6a21713 Compare March 21, 2023 09:28

RakshitKumar04 reopened this Mar 21, 2023

CatB1t removed request for vedpatwardhan and CatB1t March 22, 2023 08:59

RakshitKumar04 requested a review from kurshakuz March 22, 2023 17:07

kurshakuz suggested changes Mar 24, 2023

View reviewed changes

RakshitKumar04 force-pushed the modf-ivy-patch2 branch 2 times, most recently from a2c810c to 7d7a9d1 Compare March 25, 2023 16:31

RakshitKumar04 requested a review from kurshakuz March 26, 2023 07:39

kurshakuz suggested changes Mar 28, 2023

View reviewed changes

RakshitKumar04 force-pushed the modf-ivy-patch2 branch from 588c779 to 5970458 Compare March 29, 2023 19:59

RakshitKumar04 force-pushed the modf-ivy-patch2 branch 3 times, most recently from 02b65e5 to 08a3011 Compare April 10, 2023 09:41

RakshitKumar04 requested a review from kurshakuz April 10, 2023 10:09

RakshitKumar04 force-pushed the modf-ivy-patch2 branch 6 times, most recently from d146279 to e4ed4f6 Compare April 22, 2023 15:46

RakshitKumar04 added 10 commits April 24, 2023 01:07

Resolved conflicts

9e78669

Updated the Code

f748542

added modf to init.py file

e9418d1

Tried to resolve error

a63145f

Changed the code

94b695a

modified out variable

e26c7e5

changes the front function

4cc471d

Resolved the errors

15a6028

Edited code

cabb86e

Edited Code

3bc89de

RakshitKumar04 force-pushed the modf-ivy-patch2 branch from e4ed4f6 to 3bc89de Compare April 23, 2023 19:38

fnhirwa merged commit 325b25b into ivy-llc:master Apr 24, 2023

RakshitKumar04 mentioned this pull request Apr 24, 2023

Added modf function in jax numpy frontend #14525

Merged

RakshitKumar04 deleted the modf-ivy-patch2 branch June 20, 2023 08:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#10861 : Added modf in numpy frontend #11680

#10861 : Added modf in numpy frontend #11680

RakshitKumar04 commented Mar 3, 2023 •

edited by kurshakuz

Loading

RakshitKumar04 commented Mar 6, 2023

RakshitKumar04 commented Mar 6, 2023

RakshitKumar04 commented Mar 13, 2023

RakshitKumar04 commented Mar 14, 2023

kurshakuz left a comment •

edited

Loading

kurshakuz Mar 16, 2023

RakshitKumar04 Mar 22, 2023

RakshitKumar04 commented Mar 22, 2023

kurshakuz left a comment •

edited

Loading

RakshitKumar04 commented Mar 26, 2023 •

edited

Loading

RakshitKumar04 commented Mar 28, 2023

kurshakuz left a comment

RakshitKumar04 commented Apr 6, 2023

RakshitKumar04 commented Apr 10, 2023

kurshakuz commented Apr 12, 2023

RakshitKumar04 commented Apr 13, 2023

RakshitKumar04 commented Apr 22, 2023 •

edited

Loading

fnhirwa commented Apr 24, 2023

#10861 : Added modf in numpy frontend #11680

#10861 : Added modf in numpy frontend #11680

Conversation

RakshitKumar04 commented Mar 3, 2023 • edited by kurshakuz Loading

RakshitKumar04 commented Mar 6, 2023

RakshitKumar04 commented Mar 6, 2023

RakshitKumar04 commented Mar 13, 2023

RakshitKumar04 commented Mar 14, 2023

kurshakuz left a comment • edited Loading

Choose a reason for hiding this comment

kurshakuz Mar 16, 2023

Choose a reason for hiding this comment

RakshitKumar04 Mar 22, 2023

Choose a reason for hiding this comment

RakshitKumar04 commented Mar 22, 2023

kurshakuz left a comment • edited Loading

Choose a reason for hiding this comment

RakshitKumar04 commented Mar 26, 2023 • edited Loading

RakshitKumar04 commented Mar 28, 2023

kurshakuz left a comment

Choose a reason for hiding this comment

RakshitKumar04 commented Apr 6, 2023

RakshitKumar04 commented Apr 10, 2023

kurshakuz commented Apr 12, 2023

RakshitKumar04 commented Apr 13, 2023

RakshitKumar04 commented Apr 22, 2023 • edited Loading

fnhirwa commented Apr 24, 2023

RakshitKumar04 commented Mar 3, 2023 •

edited by kurshakuz

Loading

kurshakuz left a comment •

edited

Loading

kurshakuz left a comment •

edited

Loading

RakshitKumar04 commented Mar 26, 2023 •

edited

Loading

RakshitKumar04 commented Apr 22, 2023 •

edited

Loading