Update ParseNodeIDs to use ExpandedNodeID instead of NodeID #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devantler
changed the title
|
I have to abandon this PR. We in my team will not strictly require the functionality, so I am, under company policy, not allowed to contribute to this specific issue. For sharing what I learned prior to this decision, I believe it should be possible to retrieve the node namespace array by sending a request to "i=2255", and then use this array where the ExpandedNodeIds are resolved. Otherwise, I believe it is just an API change as demonstrated in these early changes. |
JeremyTheocharis
pushed a commit
that referenced
this pull request
Nov 16, 2023
* Update global workflows (#3) * Update global workflows (#7) * Update global workflows (#8) * Update global workflows (#10) * Update global workflows (#9) * Update global workflows (#12) * Update global workflows (#11) * Update global workflows (#13) * Update global workflows (#14) * Fix error handling and data conversion in OPCUAInput ReadBatch function * Delete .github/PULL_REQUEST_TEMPLATE.md * Delete .github/dependabot.yaml * Delete .github/CODEOWNERS * Delete .github/release-drafter.yml * Delete .github/renovate.json * Delete .github/workflows/auto-merge.yaml * Delete .github/workflows/fork-sync.yaml * Delete .github/workflows/github-readme-tree.yaml * Delete .github/workflows/todos-to-issues.yaml * Delete .github/workflows/sync-labels.yaml * Delete .github/workflows/require-labels.yaml * Delete .github/workflows/release-drafter.yaml * Final fix * Fix nil value handling in OPCUAInput ReadBatchPull method * Fix error message format in OPCUA plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
ParseNodeIDsfunction to useExpandedNodeIDinstead ofNodeID. The function now takes in a slice of strings and returns a slice ofExpandedNodeIDpointers. Additionally, the function now parses theExpandedNodeIDusing theParseExpandedNodeIDfunction and aNamespaceArrayobtained from the server. This change ensures that theParseNodeIDsfunction is up-to-date with the latest OPC-UA specifications.Fixes #5