Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure sass output file has css extension #111

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

dwightjack
Copy link
Contributor

@dwightjack dwightjack commented Jan 6, 2023

This PR should fix nuxt/module-builder#67 by forcing sass input files to be always outputted with a .css extension.

The code has been extracted from #109 for easier review.

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #111 (9acf0c8) into main (ecfd67b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   96.00%   96.00%           
=======================================
  Files           8        8           
  Lines         401      401           
  Branches       83       84    +1     
=======================================
  Hits          385      385           
  Misses         16       16           
Impacted Files Coverage Δ
src/loaders/sass.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danielroe danielroe changed the title Fix: ensure sass output file has css extension fix: ensure sass output file has css extension Jan 6, 2023
@danielroe danielroe requested a review from pi0 January 6, 2023 12:02
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@pi0 pi0 merged commit ea0c57c into unjs:main Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SCSS files get renamed with *.mjs extension
3 participants