Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong type for parsing functions. #24

Closed
c0per opened this issue Nov 25, 2024 · 0 comments · Fixed by #25
Closed

Wrong type for parsing functions. #24

c0per opened this issue Nov 25, 2024 · 0 comments · Fixed by #25
Labels
bug Something isn't working

Comments

@c0per
Copy link
Contributor

c0per commented Nov 25, 2024

Environment

Any typescript environment.

Reproduction

Use typescript types.

Describe the bug

The return type for parseTar() and parseTarGzip() should be ParsedTarFileItem[] instead of just TarFileItem[].

Additional context

In src/parse.ts:

export function parseTar(data: ArrayBuffer | Uint8Array): TarFileItem[] {
  const buffer = (data as Uint8Array).buffer || data;

  const files: ParsedTarFileItem[] = [];

  // ...

  return files;
}

It's clear that the returned type should be ParsedTarFileItem[].

I made a simple PR resolving this issue.

Logs

No response

@c0per c0per added the bug Something isn't working label Nov 25, 2024
@pi0 pi0 closed this as completed in #25 Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant