Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add readNearest* and findNearest* utilities #3

Merged
merged 9 commits into from
Oct 26, 2021

Conversation

danielroe
Copy link
Member

closes #2

@danielroe danielroe added the enhancement New feature or request label Oct 22, 2021
@danielroe danielroe requested a review from pi0 October 22, 2021 08:13
@danielroe danielroe self-assigned this Oct 22, 2021
src/fs.ts Outdated Show resolved Hide resolved
src/fs.ts Outdated Show resolved Hide resolved
src/fs.ts Outdated Show resolved Hide resolved
@danielroe danielroe requested a review from pi0 October 25, 2021 11:42
@danielroe danielroe changed the title fead: add readNearest* and findNearest* utilities feat: add readNearest* and findNearest* utilities Oct 25, 2021
@pi0
Copy link
Member

pi0 commented Oct 26, 2021

Nice work!

I have made two small changes:

  • Using async implementation to ensure forward compatiblity
  • Rename matcher to test and allow async test

@pi0 pi0 merged commit fe5997e into main Oct 26, 2021
@pi0 pi0 deleted the feat/find-and-read-json branch October 26, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

findNearestPackageJSON, readNearestPackageJSON
2 participants