Skip to content

Commit

Permalink
fix: Ensure that MauiVersion override is always applied
Browse files Browse the repository at this point in the history
  • Loading branch information
jeromelaban committed Sep 9, 2024
1 parent 7064342 commit 3d786ca
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions src/Uno.Sdk/Tasks/ImplicitPackagesResolver.cs
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,8 @@ public sealed override bool Execute()
private void SetupRuntimePackageManifestUpdates(PackageManifest manifest)
{
// Checks any MSBuild parameters passed to the task to override the default versions from the bundled packages.json
// This set of updates must not be conditional to features, as those may not be defined yet when the task
// is invoked early.
manifest.UpdateManifest(PackageManifest.Group.WasmBootstrap, UnoWasmBootstrapVersion)
.UpdateManifest(PackageManifest.Group.OSLogging, UnoLoggingVersion)
.UpdateManifest(PackageManifest.Group.CoreLogging, UnoCoreLoggingSingletonVersion)
Expand Down Expand Up @@ -260,12 +262,8 @@ private void SetupRuntimePackageManifestUpdates(PackageManifest manifest)
.UpdateManifest(PackageManifest.Group.CSharpMarkup, UnoCSharpMarkupVersion)
.UpdateManifest(PackageManifest.Group.Extensions, UnoExtensionsVersion)
.UpdateManifest(PackageManifest.Group.Toolkit, UnoToolkitVersion)
.UpdateManifest(PackageManifest.Group.Themes, UnoThemesVersion);

if (HasFeature(UnoFeature.MauiEmbedding))
{
manifest.UpdateManifest(PackageManifest.Group.Maui, MauiVersion);
}
.UpdateManifest(PackageManifest.Group.Themes, UnoThemesVersion)
.UpdateManifest(PackageManifest.Group.Maui, MauiVersion);
}

private bool HasFeature(UnoFeature feature) =>
Expand Down

0 comments on commit 3d786ca

Please sign in to comment.