You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the Navigation & Toolkit Navigation each provide an extension InitializeNavigationAsync on the Window. This should be cleaned up:
Remove Toolkit Navigation overload
Introduce an interface IInitializeViewHost that will allow the Toolkit to provide an implementation that can be resolved by the Host to configure the Loading View with the Startup Task.
// In Extensions NavigaitonpublicinterfaceIInitializeViewHost{voidInitializeViewHost(FrameworkElementelement,TaskstartupTask);}// In Toolkit NavigationinternalclassToolkitInitializeViewHost:IInitializeViewHost{publicvoidInitializeViewHost(FrameworkElementelement,TaskstartupTask){varloading=newLoadingTask(startupTask,element);if(elementisLoadingViewlv){lv.Source=loading;}}}
Add ShowAsync Extension for IApplicationBuilder
To better support the IApplicationBuilder add a reference to Extensions.Hosting.WinUI and add ShowAsync method to Extensions Navigation. Together with the IInitializeViewHost simplification this would allow it to work across both libraries. This will also clean up the Extensions Template.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Currently the Navigation & Toolkit Navigation each provide an extension
InitializeNavigationAsync
on the Window. This should be cleaned up:Remove Toolkit Navigation overload
Introduce an interface
IInitializeViewHost
that will allow the Toolkit to provide an implementation that can be resolved by the Host to configure the Loading View with the Startup Task.Add ShowAsync Extension for IApplicationBuilder
To better support the IApplicationBuilder add a reference to Extensions.Hosting.WinUI and add ShowAsync method to Extensions Navigation. Together with the
IInitializeViewHost
simplification this would allow it to work across both libraries. This will also clean up the Extensions Template.Beta Was this translation helpful? Give feedback.
All reactions