Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Skia] Image rendering is not smooth for transparent .png #16519

Closed
MartinZikmund opened this issue Apr 30, 2024 · 2 comments · Fixed by #16558
Closed

[Skia] Image rendering is not smooth for transparent .png #16519

MartinZikmund opened this issue Apr 30, 2024 · 2 comments · Fixed by #16558
Assignees
Labels
area/skia ✏️ Categorizes an issue or PR as relevant to Skia kind/bug Something isn't working project/media 📺 Categorizes an issue or PR as relevant to media (MediaPlayer, WebView, PDF, Image, …)

Comments

@MartinZikmund
Copy link
Member

Current behavior

The same transparent .png renders quite jagged on Skia targets vs other targets including WinAppSDK:

image

Expected behavior

image

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

No response

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

No response

Affected platforms

Skia (WPF), Skia (Linux X11), Skia (macOS), Skia (Linux Framebuffer), Skia (GTK)

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

@MartinZikmund MartinZikmund added kind/bug Something isn't working area/skia ✏️ Categorizes an issue or PR as relevant to Skia project/media 📺 Categorizes an issue or PR as relevant to media (MediaPlayer, WebView, PDF, Image, …) labels Apr 30, 2024
@Youssef1313
Copy link
Member

@MartinZikmund This looks like the same issue I was facing that I was going to open an issue for today :)

Image rendering will start using different APIs to ease support for Gifs starting with #15951. So we should first evaluate if #15951 will have any impact, and build a fix on top of that.

@agneszitte
Copy link
Contributor

agneszitte commented May 2, 2024

The issue is visible on the TubePlayer Sample app (Single Project) as well for .jpg images that are not transparent
Sample for repro: TubePlayer.zip - Uno.Sdk: 5.2.108 | (Details for the Youtube API Key for appsettings.development.json if needed)

@Youssef1313 I can reproduce the issue as well on the TubePlayer Sample app (non-Single Project) using previous 5.1 version. Sample for repro TubePlayer.zip - Uno.WinUI: 5.1.87

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/skia ✏️ Categorizes an issue or PR as relevant to Skia kind/bug Something isn't working project/media 📺 Categorizes an issue or PR as relevant to media (MediaPlayer, WebView, PDF, Image, …)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants