Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileOpenPicker incorrectly shows SettingsIdentifier and SuggestedStartLocation as implemented #5893

Open
2 of 24 tasks
pkar70 opened this issue May 3, 2021 · 4 comments
Open
2 of 24 tasks
Labels
difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/bug Something isn't working project/non-ui ⚙️ Categorizes an issue or PR as relevant to winrt (non-ui)

Comments

@pkar70
Copy link
Contributor

pkar70 commented May 3, 2021

Current behavior

At least on Android, FileOpenPicker has missing not implemented attribute for SettingsIdentifier and SuggestedStartLocation.

Expected behavior

These two settings should be marked as unimplemented, and decision if it can be ignored should be left to app programmer.
Or, better, these settings should be implemented.

How to reproduce it (as minimally and precisely as possible)

Workaround

None.

Environment

Nuget Package:

  • Uno.UI / Uno.UI.WebAssembly / Uno.UI.Skia
  • Uno.WinUI / Uno.WinUI.WebAssembly / Uno.WinUI.Skia
  • Uno.SourceGenerationTasks
  • Uno.UI.RemoteControl / Uno.WinUI.RemoteControl
  • Other: Uno.UWP

Nuget Package Version(s):

Affected platform(s):

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renderers for Xamarin.Forms
  • macOS
  • Skia
    • WPF
    • GTK (Linux)
    • Tizen
  • Windows
  • Build tasks
  • Solution Templates

IDE:

  • Visual Studio 2017 (version: )
  • Visual Studio 2019 (version: )
  • Visual Studio for Mac (version: )
  • Rider Windows (version: )
  • Rider macOS (version: )
  • Visual Studio Code (version: )

Relevant plugins:

  • Resharper (version: )

Anything else we need to know?

@pkar70 pkar70 added difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification labels May 3, 2021
@jeromelaban jeromelaban added project/non-ui ⚙️ Categorizes an issue or PR as relevant to winrt (non-ui) difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. and removed difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. triage/untriaged Indicates an issue requires triaging or verification labels May 3, 2021
@MartinZikmund MartinZikmund added difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI and removed difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Jun 4, 2021
@Youssef1313
Copy link
Member

Youssef1313 commented Aug 15, 2021

Looks like it's now implemented with https://github.com/unoplatform/uno/pull/5237/files#diff-25a01b26e1efd8cc1cee15bdfaad01d041a59fd807e03467780df92da8076bbeR27-R30.

GitHub
GitHub Issue (If applicable): related to #3916, #508, #3215, closes #5234, closes #5235, closes #5239 PR Type What kind of change does this PR introduce?

Feature

What is the current behavior?

Fi...

@pkar70
Copy link
Contributor Author

pkar70 commented Aug 15, 2021

Yes, SettingsIdentifier for Android is already implemented - this Issue was created just before I extracted SettingsIdentifier from my old FileOpenPicker PR #2896,
SuggestedStartLocation is harder to implement now, as Android changed API.

@Youssef1313
Copy link
Member

@pkar70 I thought both are now implemented?

@pkar70
Copy link
Contributor Author

pkar70 commented Aug 15, 2021

It is only marked as implemented. Android code doesn't use this value at all.
Code in #2896 implements SuggestedStartLocation, by using Android.OS.Environment.GetExternalStoragePublicDirectory. But This method was deprecated in API level 29, and (worse) newer Android claims that apps can have only own files, not files shared with other apps. Probably some SuggestedStartLocation can work, but as I have only tablet with Android 8.1 Go Edition, I cannot check it. My desktop is 15 years old, I cannot run Android emulator on it (or any virtual machines - CPU without SLAT).

@MartinZikmund MartinZikmund changed the title FileOpenPicker falsify shows SettingsIdentifier and SuggestedStartLocation as implemented FileOpenPicker incorrectly shows SettingsIdentifier and SuggestedStartLocation as implemented Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/bug Something isn't working project/non-ui ⚙️ Categorizes an issue or PR as relevant to winrt (non-ui)
Projects
None yet
Development

No branches or pull requests

4 participants