Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support automatically adding customized timestamp after completing tasks #9

Closed
wenlzhang opened this issue Aug 27, 2021 · 9 comments
Closed
Labels
blocked enhancement New feature or request

Comments

@wenlzhang
Copy link

Similar to what is used for scheduling tasks, it would be great if timestamp can also be added automatically when completing tasks managed by this plugin. The format can be something like the following:
Support customizing data and time into ISO format · Issue #8 · uphy/obsidian-reminder

Supporting adding task completing timestamp would also help integrating with Obsidian Tasks, which can filter tasks based on task completion date:
schemar/obsidian-tasks: Task management for the Obsidian knowledge base.

@uphy uphy added the enhancement New feature or request label Aug 30, 2021
@uphy
Copy link
Owner

uphy commented Aug 31, 2021

@wenlzhang When you use tasks plugin format, done date will be inserted with v1.0.5. Please try it.

@uphy
Copy link
Owner

uphy commented Aug 31, 2021

done-date

@wenlzhang
Copy link
Author

This looks awesome!

Similar to the discussion as follows, a space between the symbol and completion date would look better for me.
#10 (comment)

Also, Tasks uses a space between the symbol and the (completion) date, I am not sure if it would work without a space, if one wants to query completed tasks by using Tasks.

Moreover, is it possible to insert the time info when completing tasks, e.g. 2021-08-31 14:18? In case that some users may not want to attach the time info, it would be great if one can customize the date format for completing tasks. Specifically, one may define the two date and time formats: "Date and time format for identifying reminders" and "Date and time format for completing tasks".

@wenlzhang
Copy link
Author

After further testing, I observed the following:

  • When completing tasks, the original reminder date together with the completion date would be moved/appended to the end of the task.
    • For instance, - [ ] Task #Reminder 📅 2021-08-31 #Task #Life 📅 2021-09-30 would become - [ ] Task #Reminder (there are two spaces here, originally one) #Task #Life 📅 2021-09-30 📅2021-08-31 ✅2021-08-31
    • Is it possible to keep the reminder date where it is and only append the completion date at the end?
  • If the reminder only has date info but no time info, the time info would not be attached to the new reminder when postpone it by say 30 minutes.
    • For instance, - [ ] Task #Reminder 📅 2021-08-31 #Task #Life 📅 2021-09-30 would become - [ ] Task #Reminder 📅 2021-08-31 #Task #Life 📅 2021-09-30, instead of - [ ] Task #Reminder 📅 2021-08-31 09:30 #Task #Life 📅 2021-09-30.
    • For this reason, one continues to receive the reminder notification.
  • The reminder works whether there is a space or not between the symbol and the reminder date.

I also notice that one can already change the reminder from desktop notifications on macOS. Great work! 😃

@uphy
Copy link
Owner

uphy commented Sep 3, 2021

It will be fixed in the next release!

@uphy
Copy link
Owner

uphy commented Sep 4, 2021

Is it possible to keep the reminder date where it is and only append the completion date at the end?

The issue should be fixed in v1.0.6.

If the reminder only has date info but no time info, the time info would not be attached to the new reminder when postpone it by say 30 minutes.

As long as you use tasks plugin format, this cannot be fixed.
Tasks plugin doesn't support date and time format.
I'm wondering how I should handle this.

@wenlzhang
Copy link
Author

As long as you use tasks plugin format, this cannot be fixed.
Tasks plugin doesn't support date and time format.

Indeed. The current version of Tasks plugin does not support time info. @schemar I assume time info may be supported in the future, considering the following discussion?

Add optional time in addition to date to "due" · Discussion #64 · schemar/obsidian-tasks

Also, the following discussions may be relevant:

@uphy uphy added the blocked label Sep 14, 2021
@uphy
Copy link
Owner

uphy commented Sep 14, 2021

Reminder with time

You can use custom emoji ⏰ for adding time info now.
#17 (comment)

Done Date with time

Needs Tasks plugin's support.

@wenlzhang
Copy link
Author

Thanks for the update!

I realize that "Done Date" is already supported by Reminder, if the Tasks format is used. For "Done Time", I'll wait for Tasks' support on this. 😃

@uphy uphy closed this as completed Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants