fix: implement multipart progress for node (#252)

uploadcare · Apr 14, 2020 · b60eb83 · b60eb83
1 parent f5ab80a
commit b60eb83
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/src/api/multipartUpload.ts b/src/api/multipartUpload.ts
@@ -37,5 +37,12 @@ export default function multipartUpload(
     data: part,
     onProgress,
     cancel
-  }).then(({ status }) => ({ code: status }))
+  })
+    .then(result => {
+      // hack for node ¯\_(ツ)_/¯
+      if (onProgress) onProgress({ value: 1 })
+
+      return result
+    })
+    .then(({ status }) => ({ code: status }))
 }
diff --git a/src/uploadFile/uploadMultipart.ts b/src/uploadFile/uploadMultipart.ts
@@ -134,12 +134,6 @@ const uploadMultipart = (
         retryThrottledRequestMaxTimes
       })
     )
-    .then(result => {
-      // hack for node ¯\_(ツ)_/¯
-      if (onProgress) onProgress({ value: 1 })
-
-      return result
-    })
     .then(fileInfo => new UploadcareFile(fileInfo, { baseCDN }))
 }
 

diff --git a/test/api/multipartUpload.test.ts b/test/api/multipartUpload.test.ts
@@ -54,7 +54,7 @@ describe('API - multipartUpload', () => {
     )
   })
 
-  xit('should be able to handle progress', async () => {
+  it('should be able to handle progress', async () => {
     const onProgress = jest.fn()
     const options = getSettingsForTesting({
       publicKey: factory.publicKey('multipart'),