Chore/update ethers #117

fermentfan · 2023-09-13T15:52:11Z

still waiting for the ethr-did-resolver PR to merge and release, but I built it with a local link and everything runs green.

* add wrappers for resolver meta transaction methods * add tests for meta transactions * chore: bump ethr-did-resolver version that supports meta txs

fermentfan · 2023-09-14T05:59:49Z

was working on an old state of our fork without noticing... Just merged master into it and resolved all conflicts. We should just make sure we're not including those old commits. Maybe I will squash it later today.

tsconfig.json

fermentfan · 2023-09-25T10:18:25Z

@mirceanis merged master in

fermentfan · 2023-09-27T13:00:54Z

@mirceanis I switched to the newly released resolver package and it's ready for review :)

codecov · 2023-09-27T19:44:13Z

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8f90c16) 89.53% compared to head (3b06ee1) 88.25%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   89.53%   88.25%   -1.29%     
==========================================
  Files           2        1       -1     
  Lines         430      366      -64     
  Branches       74       72       -2     
==========================================
- Hits          385      323      -62     
+ Misses         45       43       -2

Files	Coverage Δ
src/index.ts	`88.25% <100.00%> (-0.46%)`	⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mirceanis

Generally looking great, and I very much appreciate the work.

Some changes are still needed, though, by the same logic as the resolver library

src/index.ts

src/__tests__/index.test.ts

src/__tests__/config.test.ts

tsconfig.json

fermentfan · 2023-09-29T11:09:09Z

I think I fixed everything now @mirceanis

mirceanis

Looks great, thanks for all the effort!

src/index.ts

mirceanis · 2023-10-03T12:26:52Z

@fermentfan looks like linter is complaining about one line.
I also spotted a function where you removed the parameter type for the transaction overrides.

Please fix these 2 issues so we can merge the PR.

I can't fix them on my end since I'm not allowed to update the PR

Co-authored-by: Mircea Nistor <[email protected]>

# [3.0.0](2.3.23...3.0.0) (2023-10-03) ### chorr * **deps:** update ethers ([#117](#117)) ([74031f6](74031f6)) ### BREAKING CHANGES * **deps:** now using ethers v6 which may cause dependency conflicts when upgrading

uport-automation-bot · 2023-10-03T13:50:19Z

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

# 1.0.0 (2024-11-14) ### Bug Fixes * **build:** export types for esm ([uport-project#106](https://github.com/coincord/ezrah-did/issues/106)) ([3b146f7](3b146f7)) * bump ethr-did-resolver to 4.3.2 ([uport-project#65](https://github.com/coincord/ezrah-did/issues/65)) ([dcd21ce](dcd21ce)), closes [uport-project#64](https://github.com/coincord/ezrah-did/issues/64) * bump release ([cc5109e](cc5109e)) * **ci:** add build step before test and release ([uport-project#90](https://github.com/coincord/ezrah-did/issues/90)) ([e4b9834](e4b9834)), closes [uport-project#89](https://github.com/coincord/ezrah-did/issues/89) * **ci:** groom the build scripts and dependencies ([uport-project#97](https://github.com/coincord/ezrah-did/issues/97)) ([0a29790](0a29790)) * **deps:** bump all dependencies to latest and fix upgrade issues ([bfd6381](bfd6381)) * **deps:** bump dependencies to more recent versions ([5e7cf20](5e7cf20)) * **deps:** bump did- dependencies to latest ([60f1e63](60f1e63)) * **deps:** bump did-jwt to v6 ([55cbf43](55cbf43)) * **deps:** bump did-jwt, did-resolver, and ethr-did-resolver packages ([uport-project#101](https://github.com/coincord/ezrah-did/issues/101)) ([a0946b3](a0946b3)) * **deps:** bump [email protected] ([60ea36c](60ea36c)) * **deps:** bump ethr-did-resolver ([uport-project#103](https://github.com/coincord/ezrah-did/issues/103)) ([180c65c](180c65c)) * **deps:** bump ethr-did-resolver to ^5.0.2 ([338839f](338839f)) * **deps:** bump ethr-did-resolver to 4.2.0 ([9b4e1b2](9b4e1b2)) * **deps:** bump ethr-did-resolver to 4.3.3 ([19064f7](19064f7)) * **deps:** bump ethr-did-resolver to 6.2.3 ([c26833a](c26833a)) * **deps:** bump ethr-did-resolver to 7.0.2 ([48c0e43](48c0e43)) * **deps:** update dependency @ethersproject/providers to v5.7.2 ([2ddb987](2ddb987)) * **deps:** Update dependency did-jwt to v7 ([4b65fce](4b65fce)) * **deps:** Update dependency did-jwt to v7.1.0 ([3860076](3860076)) * **deps:** Update dependency did-jwt to v7.2.0 ([726adc9](726adc9)) * **deps:** Update dependency did-jwt to v7.2.1 ([402b454](402b454)) * **deps:** Update dependency did-jwt to v7.2.2 ([2d33145](2d33145)) * **deps:** Update dependency did-jwt to v7.2.4 ([7c8caf1](7c8caf1)) * **deps:** Update dependency did-jwt to v7.2.5 ([daba9ff](daba9ff)) * **deps:** Update dependency did-jwt to v7.2.6 ([057a455](057a455)) * **deps:** Update dependency did-jwt to v7.2.7 ([80feeb5](80feeb5)) * **deps:** Update dependency did-jwt to v7.2.8 ([fc627b8](fc627b8)) * **deps:** Update dependency did-jwt to v7.3.0 ([9abe149](9abe149)) * **deps:** Update dependency did-jwt to v7.4.1 ([8f90c16](8f90c16)) * **deps:** Update dependency did-jwt to v7.4.2 ([e8bab95](e8bab95)) * **deps:** Update dependency did-jwt to v7.4.3 ([7a57591](7a57591)) * **deps:** Update dependency did-jwt to v7.4.4 ([09413a4](09413a4)) * **deps:** Update dependency did-jwt to v7.4.5 ([53f6cec](53f6cec)) * **deps:** Update dependency did-jwt to v7.4.6 ([37e96bc](37e96bc)) * **deps:** Update dependency did-jwt to v7.4.7 ([7b56d7a](7b56d7a)) * **deps:** Update dependency did-jwt to v8 ([d5f54da](d5f54da)) * **deps:** Update dependency did-jwt to v8.0.1 ([ffe635d](ffe635d)) * **deps:** Update dependency did-jwt to v8.0.2 ([01242e8](01242e8)) * **deps:** Update dependency did-jwt to v8.0.3 ([dfa4d0f](dfa4d0f)) * **deps:** Update dependency did-jwt to v8.0.4 ([a607c9e](a607c9e)) * **deps:** update dependency ethers to v6.10.0 ([44a26e8](44a26e8)) * **deps:** update dependency ethers to v6.11.0 ([29355d9](29355d9)) * **deps:** update dependency ethers to v6.11.1 ([da35514](da35514)) * **deps:** update dependency ethers to v6.9.1 ([4f0973a](4f0973a)) * **deps:** update dependency ethers to v6.9.2 ([dc360ab](dc360ab)) * **deps:** Update dependency ethr-did-resolver to v10.1.1 ([5391f8d](5391f8d)) * **deps:** Update dependency ethr-did-resolver to v10.1.2 ([9598d6e](9598d6e)) * **deps:** Update dependency ethr-did-resolver to v10.1.3 ([2b25174](2b25174)) * **deps:** Update dependency ethr-did-resolver to v10.1.4 ([bbe5a16](bbe5a16)) * **deps:** Update dependency ethr-did-resolver to v10.1.5 ([3f4848f](3f4848f)) * **deps:** Update dependency ethr-did-resolver to v7 ([24b23ac](24b23ac)) * **deps:** Update dependency ethr-did-resolver to v8 ([e0805e8](e0805e8)) * **deps:** Update dependency ethr-did-resolver to v8.1.1 ([fa369cd](fa369cd)) * **deps:** Update dependency ethr-did-resolver to v8.1.2 ([b3e61dc](b3e61dc)) * **deps:** Update did-dependencies ([5976e17](5976e17)) * **docs:** remove references to rinkeby ([40e0dde](40e0dde)) * stricter types, better tests ([69aee19](69aee19)) ### chorr * **deps:** update ethers ([uport-project#117](https://github.com/coincord/ezrah-did/issues/117)) ([74031f6](74031f6)) ### Features * adapt to latest did core spec and libs ([uport-project#61](https://github.com/coincord/ezrah-did/issues/61)) ([839079d](839079d)), closes [uport-project#50](https://github.com/coincord/ezrah-did/issues/50) [uport-project#59](https://github.com/coincord/ezrah-did/issues/59) [uport-project#21](https://github.com/coincord/ezrah-did/issues/21) [uport-project#49](https://github.com/coincord/ezrah-did/issues/49) [uport-project#51](https://github.com/coincord/ezrah-did/issues/51) [uport-project#52](https://github.com/coincord/ezrah-did/issues/52) [uport-project#57](https://github.com/coincord/ezrah-did/issues/57) [uport-project#58](https://github.com/coincord/ezrah-did/issues/58) * add option to specify JWT signing algorithm ([8ad8bbd](8ad8bbd)) * add support for base58 key encoding ([uport-project#62](https://github.com/coincord/ezrah-did/issues/62)) ([d0b26af](d0b26af)), closes [uport-project#60](https://github.com/coincord/ezrah-did/issues/60) * add support for meta transactions ([uport-project#102](https://github.com/coincord/ezrah-did/issues/102)) ([0ee5d98](0ee5d98)), closes [uport-project#98](https://github.com/coincord/ezrah-did/issues/98) * Typescript ([85dc7db](85dc7db)) * **updates:** Changes switching usecase from ethr to ezrah ([728e034](728e034)) * **updates:** test updates ([f8b2d9d](f8b2d9d)) * upgrade did-jwt to v3 ([uport-project#41](https://github.com/coincord/ezrah-did/issues/41)) ([7904fcf](7904fcf)) ### BREAKING CHANGES * **deps:** now using ethers v6 which may cause dependency conflicts when upgrading * new did core spec uses different format for DID documents and resolution. * Now using ethers.js which means that providers and signers may have a different API * default export was removed

strumswell and others added 10 commits September 5, 2022 11:39

add support for meta transactions (#1)

ee0c678

* add wrappers for resolver meta transaction methods * add tests for meta transactions * chore: bump ethr-did-resolver version that supports meta txs

remove deprecated hints

9ba2366

bump version of ethr-did-resolver

0e282c5

put back the deprecated hints to non-signed methods

992e062

change text for depreacted hints to its original

7615027

bump resolver version and include feedback

e7f193b

Merge branch 'master' into master

ad82bf5

chore: update ethers to v6

3c691e1

Merge branch 'master' into chore/update-ethers

c59ecf6

fix: everything for new master state

92885b4

fermentfan added 6 commits September 14, 2023 08:00

chore: remove old stuff

59cb62d

fix: bigint usage for resolver fix

c805507

fix: bigint usage in tests

536ff60

chore: switch to yarn lock

c0a81c2

Merge remote-tracking branch 'uport/master' into chore/update-ethers

0d737c8

chore: update yarn lock

7f89b2c

fermentfan commented Sep 25, 2023

View reviewed changes

tsconfig.json Show resolved Hide resolved

chore: move to newly released ethr-did-resolver

199cb15

fermentfan added 3 commits September 28, 2023 11:01

Merge remote-tracking branch 'uport/master' into chore/update-ethers

e0c89e7

fix: remove utils from test coverage

e34bea3

chore: remove unnecessary test

4add3d7

mirceanis requested changes Sep 28, 2023

View reviewed changes

src/index.ts Outdated Show resolved Hide resolved

src/__tests__/index.test.ts Show resolved Hide resolved

src/__tests__/config.test.ts Outdated Show resolved Hide resolved

tsconfig.json Show resolved Hide resolved

fermentfan added 4 commits September 29, 2023 09:34

chore: rename import to txSigner again

ee9b15a

chore: change bigint usage to number

46655d9

fix: remove unintended push

c6c67d8

chore: remove config ts

c9248b0

fix: number conversion

67e3ecc

mirceanis approved these changes Oct 3, 2023

View reviewed changes

src/index.ts Outdated Show resolved Hide resolved

fermentfan and others added 2 commits October 3, 2023 14:59

Update src/index.ts

2d72b78

Co-authored-by: Mircea Nistor <[email protected]>

chore: apply linter

3b06ee1

mirceanis merged commit 74031f6 into uport-project:master Oct 3, 2023

uport-automation-bot added the released label Oct 3, 2023

fermentfan deleted the chore/update-ethers branch October 3, 2023 15:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chore/update ethers #117

Chore/update ethers #117

fermentfan commented Sep 13, 2023

fermentfan commented Sep 14, 2023

fermentfan commented Sep 25, 2023 •

edited

Loading

fermentfan commented Sep 27, 2023

codecov bot commented Sep 27, 2023 •

edited

Loading

mirceanis left a comment

fermentfan commented Sep 29, 2023

mirceanis left a comment

mirceanis commented Oct 3, 2023

uport-automation-bot commented Oct 3, 2023

Chore/update ethers #117

Chore/update ethers #117

Conversation

fermentfan commented Sep 13, 2023

fermentfan commented Sep 14, 2023

fermentfan commented Sep 25, 2023 • edited Loading

fermentfan commented Sep 27, 2023

codecov bot commented Sep 27, 2023 • edited Loading

Codecov Report

mirceanis left a comment

Choose a reason for hiding this comment

fermentfan commented Sep 29, 2023

mirceanis left a comment

Choose a reason for hiding this comment

mirceanis commented Oct 3, 2023

uport-automation-bot commented Oct 3, 2023

fermentfan commented Sep 25, 2023 •

edited

Loading

codecov bot commented Sep 27, 2023 •

edited

Loading