Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about ringwise_flatness #69

Open
Navsea opened this issue Jan 22, 2025 · 0 comments
Open

Question about ringwise_flatness #69

Navsea opened this issue Jan 22, 2025 · 0 comments

Comments

@Navsea
Copy link

Navsea commented Jan 22, 2025

First off thank you for your work.

I wonder if the clearing of ringwise_flatness should have been placed outside of the if (!candidates.empty()) check on line 292 of v1.0.4?

Currently this vector is only cleared if we have candidates for reversion.
What if multiple rings didn't have any candidates, that would mean that ringwise_flatness contains all of data of several rings.
Or am I overlooking something?

Best regards,
Kenneth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant